Enable full type-checks in checked mode.

sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 class SsaCodeGeneratorTask extends CompilerTask {
 
   final JavaScriptBackend backend;
 
@@ skipping 2449 matching lines @@
       js.Binary notObjectOrIndexingTest =
           new js.Binary('||', objectTest, notIndexingTest);
       test = new js.Binary('&&', stringTest, notObjectOrIndexingTest);
     } else {
       compiler.internalError('Unexpected type guard', instruction: input);
     }
     return test;
   }
 
   void visitTypeConversion(HTypeConversion node) {
-    if (node.isChecked) {
-      if (node.isArgumentTypeCheck || node.isReceiverTypeCheck) {
-        js.Expression test = generateTest(node);
-        js.Block oldContainer = currentContainer;
-        js.Statement body = new js.Block.empty();
-        currentContainer = body;
-        if (node.isArgumentTypeCheck) {
-          generateThrowWithHelper('iae', node.checkedInput);
-        } else if (node.isReceiverTypeCheck) {
-          use(node.checkedInput);
-          String methodName =
-              backend.namer.invocationName(node.receiverTypeCheckSelector);
-          js.Expression call = jsPropertyCall(pop(), methodName, []);
-          pushStatement(new js.Throw(call));
-        }
-        currentContainer = oldContainer;
-        body = unwrapStatement(body);
-        pushStatement(new js.If.noElse(test, body), node);
-        return;
+    if (!node.isChecked) {
+      use(node.checkedInput);
+      return;
+    } else if (node.isArgumentTypeCheck || node.isReceiverTypeCheck) {

[ngeoffray, 2013/05/13 09:10:59]

I would remove the else.

[karlklose, 2013/05/14 13:49:41]

Done.

+      js.Expression test = generateTest(node);
+      js.Block oldContainer = currentContainer;
+      js.Statement body = new js.Block.empty();
+      currentContainer = body;
+      if (node.isArgumentTypeCheck) {
+        generateThrowWithHelper('iae', node.checkedInput);
+      } else if (node.isReceiverTypeCheck) {
+        use(node.checkedInput);
+        String methodName =
+            backend.namer.invocationName(node.receiverTypeCheckSelector);
+        js.Expression call = jsPropertyCall(pop(), methodName, []);
+        pushStatement(new js.Throw(call));
       }
+      currentContainer = oldContainer;
+      body = unwrapStatement(body);
+      pushStatement(new js.If.noElse(test, body), node);
+      return;
+    }
 
-      assert(node.isCheckedModeCheck || node.isCastTypeCheck);
-      DartType type = node.typeExpression;
-      world.registerIsCheck(type, work.resolutionTree);
+    assert(node.isCheckedModeCheck || node.isCastTypeCheck);
+    DartType type = node.typeExpression;
+    world.registerIsCheck(type, work.resolutionTree);
 
-      // TODO(kasperl): For now, we ignore type checks against type
-      // variables. This is clearly wrong.
-      if (type.kind == TypeKind.TYPE_VARIABLE) {
-        use(node.checkedInput);
-        return;
-      }
-
-      FunctionElement helperElement;
-      if (node.isBooleanConversionCheck) {
-        helperElement =
-            compiler.findHelper(const SourceString('boolConversionCheck'));
-      } else {
-        helperElement = backend.getCheckedModeHelper(type,
-            typeCast: node.isCastTypeCheck);
-      }
-      world.registerStaticUse(helperElement);
-      List<js.Expression> arguments = <js.Expression>[];
-      use(node.checkedInput);
+    FunctionElement helperElement;
+    if (node.isBooleanConversionCheck) {
+      helperElement =
+          compiler.findHelper(const SourceString('boolConversionCheck'));
+    } else {
+      helperElement = backend.getCheckedModeHelper(type,
+          typeCast: node.isCastTypeCheck);
+    }
+    world.registerStaticUse(helperElement);
+    List<js.Expression> arguments = <js.Expression>[];
+    use(node.checkedInput);
+    arguments.add(pop());
+    int parameterCount =
+        helperElement.computeSignature(compiler).parameterCount;
+    // TODO(johnniwinther): Refactor this to avoid using the parameter count
+    // to determine how the helper should be called.
+    if (node.typeExpression.kind == TypeKind.TYPE_VARIABLE) {
+      assert(parameterCount == 2);
+      use(node.typeRepresentation);
       arguments.add(pop());
-      int parameterCount =
-          helperElement.computeSignature(compiler).parameterCount;
-      // TODO(johnniwinther): Refactor this to avoid using the parameter count
-      // to determine how the helper should be called.
-      if (parameterCount == 2) {
-        // 2 arguments implies that the method is either [propertyTypeCheck]
-        // or [propertyTypeCast].
-        assert(!type.isMalformed);
-        String additionalArgument = backend.namer.operatorIs(type.element);
-        arguments.add(js.string(additionalArgument));
-      } else if (parameterCount == 3) {
-        // 3 arguments implies that the method is [malformedTypeCheck].
-        assert(type.isMalformed);
-        String reasons = Types.fetchReasonsFromMalformedType(type);
-        arguments.add(js.string('$type'));
-        // TODO(johnniwinther): Handle escaping correctly.
-        arguments.add(js.string(reasons));
-      } else {
-        assert(!type.isMalformed);
-      }
-      String helperName = backend.namer.isolateAccess(helperElement);
-      push(new js.Call(new js.VariableUse(helperName), arguments));
+    } else if (parameterCount == 2) {
+      // 2 arguments implies that the method is either [propertyTypeCheck],
+      // [propertyTypeCast] or [assertObjectIsSubtype].
+      assert(!type.isMalformed);
+      String additionalArgument = backend.namer.operatorIs(type.element);
+      arguments.add(js.string(additionalArgument));
+    } else if (parameterCount == 3) {
+      // 3 arguments implies that the method is [malformedTypeCheck].
+      assert(type.isMalformed);
+      String reasons = Types.fetchReasonsFromMalformedType(type);
+      arguments.add(js.string('$type'));
+      // TODO(johnniwinther): Handle escaping correctly.
+      arguments.add(js.string(reasons));
+    } else if (parameterCount == 4) {
+      Element element = type.element;
+      String isField = backend.namer.operatorIs(element);
+      arguments.add(js.string(isField));
+      use(node.typeRepresentation);
+      arguments.add(pop());
+      String asField = backend.namer.substitutionName(element);
+      arguments.add(js.string(asField));
     } else {
-      use(node.checkedInput);
+      assert(!type.isMalformed);
+      // No additional arguments needed.
     }
+    String helperName = backend.namer.isolateAccess(helperElement);
+    push(new js.Call(new js.VariableUse(helperName), arguments));
   }
 }
 
 class SsaOptimizedCodeGenerator extends SsaCodeGenerator {
   SsaOptimizedCodeGenerator(backend, work) : super(backend, work);
 
   HBasicBlock beginGraph(HGraph graph) {
     return graph.entry;
   }
 
@@ skipping 427 matching lines @@
   if (leftType.canBeNull() && rightType.canBeNull()) {
     if (left.isConstantNull() || right.isConstantNull() ||
         (leftType.isPrimitive() && leftType == rightType)) {
       return '==';
     }
     return null;
   } else {
     return '===';
   }
 }