win: Crash handler server

util/win/registration_protocol_win.h

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef CRASHPAD_CLIENT_REGISTRATION_PROTOCOL_WIN_H_
-#define CRASHPAD_CLIENT_REGISTRATION_PROTOCOL_WIN_H_
+#ifndef CRASHPAD_UTIL_WIN_REGISTRATION_PROTOCOL_WIN_H_
+#define CRASHPAD_UTIL_WIN_REGISTRATION_PROTOCOL_WIN_H_
 
 #include <windows.h>
 #include <stdint.h>
 
+#include "base/strings/string16.h"
 #include "util/win/address_types.h"
 
 namespace crashpad {
 
 #pragma pack(push, 1)
+
+//! \brief Structure read out of the client process by the crash handler when an
+//!     exception occurs.
+struct ExceptionInformation {
+  //! \brief The thread on which the exception happened.
+  DWORD thread_id;
+
+  //! \brief The address of an EXCEPTION_POINTERS structure in the client
+  //!     process that describes the exception.
+  WinVMAddress exception_pointers;

[Mark Mentovai, 2015/08/26 21:40:28]

Packs better if the WinVMAddress comes before the DWORD. Same in
RegistrationRequest, but consider the next comment too.

[scottmg, 2015/08/27 01:04:38]

Done.

+};
+
 //! \brief A client registration request.
 struct RegistrationRequest {
   //! \brief The PID of the client process.
   DWORD client_process_id;

[Mark Mentovai, 2015/08/26 21:40:28]

Can the server determine this from the message without the client having to
specify it? I’d rather not have the server trust the client for this kind of
thing. (After reading a bit more) looks like you considered this but you can
only get it on Vista and later…

[scottmg, 2015/08/27 01:04:38]

Right, I don't think it's possible on XP. (swapped the order here too)

-  //! \brief The address, in the client process address space, of a CrashpadInfo
-  //!     structure.
-  crashpad::WinVMAddress crashpad_info_address;
+
+  //! \brief The address, in the client process address space, of an
+  //!     ExceptionInformation structure.
+  WinVMAddress exception_information;
 };
-#pragma pack(pop)
 
-#pragma pack(push, 1)
 //! \brief  A client registration response.
 //!
 //! See <a
 //! href="https://msdn.microsoft.com/en-us/library/windows/desktop/aa384203">Interprocess
 //! Communication Between 32-bit and 64-bit Applications</a> for details on
 //! communicating handle values between processes of varying bitness.
 struct RegistrationResponse {
   //! \brief An event `HANDLE`, valid in the client process, that should be
   //!     signaled to request a crash report. 64-bit clients should convert the
   //!     value to a `HANDLE` using sign-extension.
   uint32_t request_report_event;
-  //! \brief An event `HANDLE`, valid in the client process, that will be
-  //!     signaled when the requested crash report is complete. 64-bit clients
-  //!     should convert the value to a `HANDLE` using sign-extension.
-  uint32_t report_complete_event;
 };
+
 #pragma pack(pop)
 
+namespace internal {
+
+//! \brief Connect over the given \a pipe_name, passing \a request to the
+//!     server, and reading its reply into \a response.
+//!
+//! Typically clients will not use this directly, instead using
+//! CrashpadClient::SetHandler().
+//!
+//! \sa CrashpadClient::SetHandler()
+bool RegisterWithCrashHandlerServer(const base::string16& pipe_name,
+                                    const RegistrationRequest& request,
+                                    RegistrationResponse* response);
+
+}  // namespace internal
+
 }  // namespace crashpad
 
-#endif  // CRASHPAD_CLIENT_REGISTRATION_PROTOCOL_WIN_H_
+#endif  // CRASHPAD_UTIL_WIN_REGISTRATION_PROTOCOL_WIN_H_