Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/shim/main.js

Issue 130183004: <webview>: Add better loadabort reason messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reupload Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/platform_apps/web_view/shim/main.js
diff --git a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js b/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
index 3f0337decc74f8328a2b63bfaac9c00d2b027770..b772dd1f0fc7b85ffd5e8098e76bef969904d05a 100644
--- a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
+++ b/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
@@ -1047,7 +1047,7 @@ function testLoadAbortIllegalChromeURL() {
};
webview.addEventListener('loadstop', onFirstLoadStop);
webview.addEventListener('loadabort', function(e) {
- embedder.test.assertEq('ERR_ABORTED', e.reason);
+ embedder.test.assertEq('ERR_DISALLOWED_URL_SCHEME', e.reason);
embedder.test.succeed();
});
webview.setAttribute('src', 'about:blank');
@@ -1057,7 +1057,7 @@ function testLoadAbortIllegalChromeURL() {
function testLoadAbortIllegalFileURL() {
var webview = document.createElement('webview');
webview.addEventListener('loadabort', function(e) {
- embedder.test.assertEq('ERR_ABORTED', e.reason);
+ embedder.test.assertEq('ERR_DISALLOWED_URL_SCHEME', e.reason);
embedder.test.succeed();
});
webview.setAttribute('src', 'file://foo');
@@ -1067,7 +1067,7 @@ function testLoadAbortIllegalFileURL() {
function testLoadAbortIllegalJavaScriptURL() {
var webview = document.createElement('webview');
webview.addEventListener('loadabort', function(e) {
- embedder.test.assertEq('ERR_ABORTED', e.reason);
+ embedder.test.assertEq('ERR_DISALLOWED_URL_SCHEME', e.reason);
embedder.test.succeed();
});
webview.setAttribute('src', 'javascript:void(document.bgColor="#0000FF")');
@@ -1144,8 +1144,7 @@ function testNavigationToExternalProtocol() {
var webview = document.createElement('webview');
webview.addEventListener('loadstop', function(e) {
webview.addEventListener('loadabort', function(e) {
- // TODO(fsamuel): Change to ERR_UNKNOWN_URL_SCHEME.
- embedder.test.assertEq('ERR_ABORTED', e.reason);
+ embedder.test.assertEq('ERR_DISALLOWED_URL_SCHEME', e.reason);
embedder.test.succeed();
});
webview.executeScript({
@@ -1290,7 +1289,7 @@ function testNavigateToWebStore() {
webview.addEventListener('loadabort', function(e) {
e.preventDefault();
window.console.log('Navigation to \'' + e.url + '\' has been aborted.');
- embedder.test.assertEq('ERR_ABORTED', e.reason);
+ embedder.test.assertEq('ERR_ACCESS_DENIED', e.reason);
embedder.test.assertEq(CHROME_WEB_STORE, e.url);
// Ask the guest process if it's still alive. If the guest process has
// crashed then this message will never be received.

Powered by Google App Engine
This is Rietveld 408576698