<webview>: Add better loadabort reason messages

<webview>: Add better loadabort reason messages

This CL adds the following loadabort reasons:

ERR_INVALID_URL
ERR_DISALLOWED_URL_SCHEME
ERR_ACCESS_DENIED

BUG=341097
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249498

[lazyboy, 2014-02-05 19:08:40]

lgtm

https://codereview.chromium.org/130183004/diff/20001/content/browser/browser_...
File content/browser/browser_plugin/browser_plugin_guest.h (right):

https://codereview.chromium.org/130183004/diff/20001/content/browser/browser_...
content/browser/browser_plugin/browser_plugin_guest.h:355: static bool
SupportsScheme(const GURL& url);
feel free to ignore: Might consider moving this to anonymous namespace in the cc
file.

[Fady Samuel, 2014-02-05 19:25:31]

Addressed nit. CQ'ing

https://codereview.chromium.org/130183004/diff/20001/content/browser/browser_...
File content/browser/browser_plugin/browser_plugin_guest.h (right):

https://codereview.chromium.org/130183004/diff/20001/content/browser/browser_...
content/browser/browser_plugin/browser_plugin_guest.h:355: static bool
SupportsScheme(const GURL& url);
On 2014/02/05 19:08:41, lazyboy wrote:
> feel free to ignore: Might consider moving this to anonymous namespace in the
cc
> file.

Done.

[Fady Samuel, 2014-02-05 22:41:55]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-02-05 22:45:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/130183004/80001

[commit-bot: I haz the power, 2014-02-06 08:26:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-06 08:26:02]

Retried try job too often on linux_clang for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[Fady Samuel, 2014-02-06 11:11:32]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-02-06 11:13:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/130183004/80001

[commit-bot: I haz the power, 2014-02-06 11:13:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-06 11:13:47]

Failed to apply patch for
chrome/test/data/extensions/platform_apps/web_view/shim/main.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/test/data/extensions/platform_apps/web_view/shim/main.js
  Hunk #4 FAILED at 1144.
  Hunk #5 FAILED at 1290.
  2 out of 5 hunks FAILED -- saving rejects to file
chrome/test/data/extensions/platform_apps/web_view/shim/main.js.rej

Patch:       chrome/test/data/extensions/platform_apps/web_view/shim/main.js
Index: chrome/test/data/extensions/platform_apps/web_view/shim/main.js
diff --git a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
b/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
index
3f0337decc74f8328a2b63bfaac9c00d2b027770..b772dd1f0fc7b85ffd5e8098e76bef969904d05a
100644
--- a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
+++ b/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
@@ -1047,7 +1047,7 @@ function testLoadAbortIllegalChromeURL() {
   };
   webview.addEventListener('loadstop', onFirstLoadStop);
   webview.addEventListener('loadabort', function(e) {
-    embedder.test.assertEq('ERR_ABORTED', e.reason);
+    embedder.test.assertEq('ERR_DISALLOWED_URL_SCHEME', e.reason);
     embedder.test.succeed();
   });
   webview.setAttribute('src', 'about:blank');
@@ -1057,7 +1057,7 @@ function testLoadAbortIllegalChromeURL() {
 function testLoadAbortIllegalFileURL() {
   var webview = document.createElement('webview');
   webview.addEventListener('loadabort', function(e) {
-    embedder.test.assertEq('ERR_ABORTED', e.reason);
+    embedder.test.assertEq('ERR_DISALLOWED_URL_SCHEME', e.reason);
     embedder.test.succeed();
   });
   webview.setAttribute('src', 'file://foo');
@@ -1067,7 +1067,7 @@ function testLoadAbortIllegalFileURL() {
 function testLoadAbortIllegalJavaScriptURL() {
   var webview = document.createElement('webview');
   webview.addEventListener('loadabort', function(e) {
-    embedder.test.assertEq('ERR_ABORTED', e.reason);
+    embedder.test.assertEq('ERR_DISALLOWED_URL_SCHEME', e.reason);
     embedder.test.succeed();
   });
   webview.setAttribute('src', 'javascript:void(document.bgColor="#0000FF")');
@@ -1144,8 +1144,7 @@ function testNavigationToExternalProtocol() {
   var webview = document.createElement('webview');
   webview.addEventListener('loadstop', function(e) {
     webview.addEventListener('loadabort', function(e) {
-      // TODO(fsamuel): Change to ERR_UNKNOWN_URL_SCHEME.
-      embedder.test.assertEq('ERR_ABORTED', e.reason);
+      embedder.test.assertEq('ERR_DISALLOWED_URL_SCHEME', e.reason);
       embedder.test.succeed();
     });
     webview.executeScript({
@@ -1290,7 +1289,7 @@ function testNavigateToWebStore() {
   webview.addEventListener('loadabort', function(e) {
     e.preventDefault();
     window.console.log('Navigation to \'' + e.url + '\' has been aborted.');
-    embedder.test.assertEq('ERR_ABORTED', e.reason);
+    embedder.test.assertEq('ERR_ACCESS_DENIED', e.reason);
     embedder.test.assertEq(CHROME_WEB_STORE, e.url);
     // Ask the guest process if it's still alive. If the guest process has
     // crashed then this message will never be received.

[Fady Samuel, 2014-02-06 20:50:10]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-02-06 20:53:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/130183004/80001

[commit-bot: I haz the power, 2014-02-06 21:09:24]

Change committed as 249498