Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1301823005: Reland of Implement canComputeFastBounds() for image filters. (Closed)

Created:
5 years, 4 months ago by Stephen White
Modified:
5 years, 4 months ago
Reviewers:
herb_g, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of Implement canComputeFastBounds() for image filters. (patchset #1 id:1 of https://codereview.chromium.org/1300403003/ ) Reason for revert: The Mac compile issue was fixed here: https://chromium.googlesource.com/chromium/src/+/fdd331a42ae0b9a6909a121020735161ab61c6e5 Original issue's description: > Revert of Implement canComputeFastBounds() for image filters. (patchset #8 id:130001 of https://codereview.chromium.org/1296943002/ ) > > Reason for revert: > This causes a syntax error. > > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/87819/steps/compile%20%28with%20patch%29/logs/stdio > > Original issue's description: > > Implement canComputeFastBounds() for image filters. > > > > Image filters have never implemented this check, which means that > > filters which affect transparent black falsely claim they can compute > > their bounds. > > > > Implemented an affectsTransparentBlack() virtual for image > > filters, and a similar helper function for color filters. > > > > This will affect the following GMs: imagefiltersscaled > > (lighting, perlin noise now filter to clip), > > colorfilterimagefilter (new test case), imagefiltersclipped > > (perlin noise now filters to clip). > > > > Note: I de-inlined SkPaint::canComputeFastBounds() to avoid adding > > a dependency from SkPaint.h to SkImageFilter.h.h. Skia benches show > > no impact from this change, but will watch the perf bots carefully. > > > > BUG=4212 > > > > Committed: https://skia.googlesource.com/skia/+/915881fe743f9a789037695f543bc6ea189cd0cb > > TBR=reed@google.com,senorblanco@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=4212 > > Committed: https://skia.googlesource.com/skia/+/12d8472d31ea5edb636d7d5214db253570115c40 TBR=reed@google.com,herb@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=4212 Committed: https://skia.googlesource.com/skia/+/0abdf766d395ed3b7059511425f431589eca05f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -8 lines) Patch
M gm/colorfilterimagefilter.cpp View 2 chunks +7 lines, -1 line 0 comments Download
M gm/imagefiltersscaled.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkColorFilter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M include/core/SkImageFilter.h View 3 chunks +12 lines, -0 lines 0 comments Download
M include/core/SkPaint.h View 3 chunks +2 lines, -7 lines 0 comments Download
M include/effects/SkColorFilterImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkLightingImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkRectShaderImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/effects/SkRectShaderImageFilter.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/ImageFilterTest.cpp View 2 chunks +53 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Stephen White
Created Reland of Implement canComputeFastBounds() for image filters.
5 years, 4 months ago (2015-08-20 18:10:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301823005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301823005/1
5 years, 4 months ago (2015-08-20 18:10:36 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 18:10:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0abdf766d395ed3b7059511425f431589eca05f6

Powered by Google App Engine
This is Rietveld 408576698