Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Side by Side Diff: Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 1301813002: DevTools: propagate experiments that are enabled by default into default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments addressed Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 711 matching lines...) Expand 10 before | Expand all | Expand 10 after
722 722
723 this.textEditor.setExecutionLocation(uiLocation.lineNumber, uiLocation.c olumnNumber); 723 this.textEditor.setExecutionLocation(uiLocation.lineNumber, uiLocation.c olumnNumber);
724 if (this.isShowing()) { 724 if (this.isShowing()) {
725 // We need CodeMirrorTextEditor to be initialized prior to this call . @see crbug.com/506566 725 // We need CodeMirrorTextEditor to be initialized prior to this call . @see crbug.com/506566
726 setImmediate(this._generateValuesInSource.bind(this)); 726 setImmediate(this._generateValuesInSource.bind(this));
727 } 727 }
728 }, 728 },
729 729
730 _generateValuesInSource: function() 730 _generateValuesInSource: function()
731 { 731 {
732 if (!Runtime.experiments.isEnabled("inlineVariableValues") || !WebInspec tor.moduleSetting("inlineVariableValues").get()) 732 if (!WebInspector.moduleSetting("inlineVariableValues").get())
733 return; 733 return;
734 var executionContext = WebInspector.context.flavor(WebInspector.Executio nContext); 734 var executionContext = WebInspector.context.flavor(WebInspector.Executio nContext);
735 if (!executionContext) 735 if (!executionContext)
736 return; 736 return;
737 var callFrame = executionContext.debuggerModel.selectedCallFrame(); 737 var callFrame = executionContext.debuggerModel.selectedCallFrame();
738 if (!callFrame) 738 if (!callFrame)
739 return; 739 return;
740 740
741 var localScope = callFrame.localScope(); 741 var localScope = callFrame.localScope();
742 var functionLocation = callFrame.functionLocation(); 742 var functionLocation = callFrame.functionLocation();
(...skipping 383 matching lines...) Expand 10 before | Expand all | Expand 10 after
1126 this._uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events. WorkingCopyChanged, this._workingCopyChanged, this); 1126 this._uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events. WorkingCopyChanged, this._workingCopyChanged, this);
1127 this._uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events. WorkingCopyCommitted, this._workingCopyCommitted, this); 1127 this._uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events. WorkingCopyCommitted, this._workingCopyCommitted, this);
1128 this._uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events. TitleChanged, this._showBlackboxInfobarIfNeeded, this); 1128 this._uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events. TitleChanged, this._showBlackboxInfobarIfNeeded, this);
1129 WebInspector.moduleSetting("skipStackFramesPattern").removeChangeListene r(this._showBlackboxInfobarIfNeeded, this); 1129 WebInspector.moduleSetting("skipStackFramesPattern").removeChangeListene r(this._showBlackboxInfobarIfNeeded, this);
1130 WebInspector.moduleSetting("skipContentScripts").removeChangeListener(th is._showBlackboxInfobarIfNeeded, this); 1130 WebInspector.moduleSetting("skipContentScripts").removeChangeListener(th is._showBlackboxInfobarIfNeeded, this);
1131 WebInspector.UISourceCodeFrame.prototype.dispose.call(this); 1131 WebInspector.UISourceCodeFrame.prototype.dispose.call(this);
1132 }, 1132 },
1133 1133
1134 __proto__: WebInspector.UISourceCodeFrame.prototype 1134 __proto__: WebInspector.UISourceCodeFrame.prototype
1135 } 1135 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/sdk/Target.js ('k') | Source/devtools/front_end/sources/SourcesPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698