Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: Source/devtools/front_end/sources/SourcesPanel.js

Issue 1301813002: DevTools: propagate experiments that are enabled by default into default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 68
69 this.sidebarPanes = {}; 69 this.sidebarPanes = {};
70 this.sidebarPanes.threads = new WebInspector.ThreadsSidebarPane(); 70 this.sidebarPanes.threads = new WebInspector.ThreadsSidebarPane();
71 this.sidebarPanes.watchExpressions = new WebInspector.WatchExpressionsSideba rPane(); 71 this.sidebarPanes.watchExpressions = new WebInspector.WatchExpressionsSideba rPane();
72 this.sidebarPanes.callstack = new WebInspector.CallStackSidebarPane(); 72 this.sidebarPanes.callstack = new WebInspector.CallStackSidebarPane();
73 this.sidebarPanes.callstack.addEventListener(WebInspector.CallStackSidebarPa ne.Events.CallFrameSelected, this._callFrameSelectedInSidebar.bind(this)); 73 this.sidebarPanes.callstack.addEventListener(WebInspector.CallStackSidebarPa ne.Events.CallFrameSelected, this._callFrameSelectedInSidebar.bind(this));
74 this.sidebarPanes.callstack.addEventListener(WebInspector.CallStackSidebarPa ne.Events.RevealHiddenCallFrames, this._hiddenCallFramesRevealedInSidebar.bind(t his)); 74 this.sidebarPanes.callstack.addEventListener(WebInspector.CallStackSidebarPa ne.Events.RevealHiddenCallFrames, this._hiddenCallFramesRevealedInSidebar.bind(t his));
75 this.sidebarPanes.callstack.registerShortcuts(this.registerShortcuts.bind(th is)); 75 this.sidebarPanes.callstack.registerShortcuts(this.registerShortcuts.bind(th is));
76 76
77 this.sidebarPanes.scopechain = new WebInspector.ScopeChainSidebarPane(); 77 this.sidebarPanes.scopechain = new WebInspector.ScopeChainSidebarPane();
78 if (Runtime.experiments.isEnabled("serviceWorkersInPageFrontend")) 78 this.sidebarPanes.serviceWorkers = new WebInspector.ServiceWorkersSidebarPan e();
79 this.sidebarPanes.serviceWorkers = new WebInspector.ServiceWorkersSideba rPane();
80 this.sidebarPanes.jsBreakpoints = new WebInspector.JavaScriptBreakpointsSide barPane(WebInspector.breakpointManager, this.showUISourceCode.bind(this)); 79 this.sidebarPanes.jsBreakpoints = new WebInspector.JavaScriptBreakpointsSide barPane(WebInspector.breakpointManager, this.showUISourceCode.bind(this));
81 this.sidebarPanes.domBreakpoints = WebInspector.domBreakpointsSidebarPane.cr eateProxy(this); 80 this.sidebarPanes.domBreakpoints = WebInspector.domBreakpointsSidebarPane.cr eateProxy(this);
82 this.sidebarPanes.xhrBreakpoints = new WebInspector.XHRBreakpointsSidebarPan e(); 81 this.sidebarPanes.xhrBreakpoints = new WebInspector.XHRBreakpointsSidebarPan e();
83 this.sidebarPanes.eventListenerBreakpoints = new WebInspector.EventListenerB reakpointsSidebarPane(); 82 this.sidebarPanes.eventListenerBreakpoints = new WebInspector.EventListenerB reakpointsSidebarPane();
84 this.sidebarPanes.objectEventListeners = new WebInspector.ObjectEventListene rsSidebarPane(); 83 this.sidebarPanes.objectEventListeners = new WebInspector.ObjectEventListene rsSidebarPane();
85 if (Runtime.experiments.isEnabled("stepIntoAsync")) 84 if (Runtime.experiments.isEnabled("stepIntoAsync"))
86 this.sidebarPanes.asyncOperationBreakpoints = new WebInspector.AsyncOper ationsSidebarPane(); 85 this.sidebarPanes.asyncOperationBreakpoints = new WebInspector.AsyncOper ationsSidebarPane();
87 86
88 this._lastSelectedTabSetting = WebInspector.settings.createLocalSetting("las tSelectedSourcesSidebarPaneTab", this.sidebarPanes.scopechain.title()); 87 this._lastSelectedTabSetting = WebInspector.settings.createLocalSetting("las tSelectedSourcesSidebarPaneTab", this.sidebarPanes.scopechain.title());
89 88
(...skipping 693 matching lines...) Expand 10 before | Expand all | Expand 10 after
783 return debugToolbarDrawer; 782 return debugToolbarDrawer;
784 }, 783 },
785 784
786 /** 785 /**
787 * @param {!WebInspector.ToolbarButton} button 786 * @param {!WebInspector.ToolbarButton} button
788 * @param {string} buttonTitle 787 * @param {string} buttonTitle
789 */ 788 */
790 _updateButtonTitle: function(button, buttonTitle) 789 _updateButtonTitle: function(button, buttonTitle)
791 { 790 {
792 var hasShortcuts = button._shortcuts && button._shortcuts.length; 791 var hasShortcuts = button._shortcuts && button._shortcuts.length;
793 if (hasShortcuts && Runtime.experiments.isEnabled("tooltips")) 792 if (hasShortcuts)
794 button.setTitle(buttonTitle); 793 button.setTitle(buttonTitle);
795 else if (hasShortcuts) 794 else if (hasShortcuts)
dgozman 2015/08/18 21:58:43 This code is unreachable.
pfeldman 2015/08/18 23:50:55 Good catch :)
pfeldman 2015/08/19 00:00:05 Done.
796 button.setTitle(WebInspector.UIString(buttonTitle + " (%s)", button. _shortcuts[0].name)); 795 button.setTitle(WebInspector.UIString(buttonTitle + " (%s)", button. _shortcuts[0].name));
797 else 796 else
798 button.setTitle(buttonTitle); 797 button.setTitle(buttonTitle);
799 }, 798 },
800 799
801 /** 800 /**
802 * @param {string} buttonId 801 * @param {string} buttonId
803 * @param {string} buttonTitle 802 * @param {string} buttonTitle
804 * @param {string} actionId 803 * @param {string} actionId
805 * @return {!WebInspector.ToolbarButton} 804 * @return {!WebInspector.ToolbarButton}
(...skipping 658 matching lines...) Expand 10 before | Expand all | Expand 10 after
1464 WebInspector.SourcesPanelFactory.prototype = { 1463 WebInspector.SourcesPanelFactory.prototype = {
1465 /** 1464 /**
1466 * @override 1465 * @override
1467 * @return {!WebInspector.Panel} 1466 * @return {!WebInspector.Panel}
1468 */ 1467 */
1469 createPanel: function() 1468 createPanel: function()
1470 { 1469 {
1471 return WebInspector.SourcesPanel.instance(); 1470 return WebInspector.SourcesPanel.instance();
1472 } 1471 }
1473 } 1472 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698