Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1301813002: DevTools: propagate experiments that are enabled by default into default. (Closed)

Created:
5 years, 4 months ago by pfeldman
Modified:
5 years, 4 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: propagate experiments that are enabled by default into default. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200777

Patch Set 1 #

Total comments: 6

Patch Set 2 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -39 lines) Patch
M Source/devtools/front_end/main/AdvancedApp.js View 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 3 chunks +1 line, -8 lines 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 5 chunks +4 lines, -20 lines 0 comments Download
M Source/devtools/front_end/ui/Tooltip.js View 1 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
pfeldman
5 years, 4 months ago (2015-08-18 20:55:42 UTC) #2
dgozman
https://codereview.chromium.org/1301813002/diff/1/Source/devtools/front_end/main/AdvancedApp.js File Source/devtools/front_end/main/AdvancedApp.js (left): https://codereview.chromium.org/1301813002/diff/1/Source/devtools/front_end/main/AdvancedApp.js#oldcode67 Source/devtools/front_end/main/AdvancedApp.js:67: if (Runtime.experiments.isEnabled("tooltips")) There should be more usages in Tooltip.js. ...
5 years, 4 months ago (2015-08-18 21:58:43 UTC) #3
pfeldman
https://codereview.chromium.org/1301813002/diff/1/Source/devtools/front_end/main/AdvancedApp.js File Source/devtools/front_end/main/AdvancedApp.js (left): https://codereview.chromium.org/1301813002/diff/1/Source/devtools/front_end/main/AdvancedApp.js#oldcode67 Source/devtools/front_end/main/AdvancedApp.js:67: if (Runtime.experiments.isEnabled("tooltips")) On 2015/08/18 21:58:43, dgozman wrote: > There ...
5 years, 4 months ago (2015-08-18 23:50:55 UTC) #4
pfeldman
https://codereview.chromium.org/1301813002/diff/1/Source/devtools/front_end/main/AdvancedApp.js File Source/devtools/front_end/main/AdvancedApp.js (left): https://codereview.chromium.org/1301813002/diff/1/Source/devtools/front_end/main/AdvancedApp.js#oldcode67 Source/devtools/front_end/main/AdvancedApp.js:67: if (Runtime.experiments.isEnabled("tooltips")) On 2015/08/18 23:50:55, pfeldman wrote: > On ...
5 years, 4 months ago (2015-08-19 00:00:05 UTC) #5
dgozman
lgtm
5 years, 4 months ago (2015-08-19 00:11:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301813002/20001
5 years, 4 months ago (2015-08-19 00:12:13 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 01:38:46 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200777

Powered by Google App Engine
This is Rietveld 408576698