Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1301793002: Merge to XFA: CFX_MapByteStringToPtr considered harmful (combo patch). (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: CFX_MapByteStringToPtr considered harmful (combo patch). New manual edits: two unused members deleted, one adapted. fde_csscache.cpp fde_csscache.h fpdfxfa_doc.h fx_ge_fontmap.cpp (cherry picked from commit 1d9dbd53b205b2b4d9e75a7eeb95e80837917ea3) (cherry picked from commit cb4d0ea68308e3c51a6ba9551b393bb2f639afc4) (cherry picked from commit 9cf44c2ed09a8b2ff243eb6dbb72a8cceae1b5ff) (cherry picked from commit 2a2a6aa7f51352fc481e78f6ad9d41f2738bcc48) (cherry picked from commit ce4ffb8183af3fa2bb5133f0f7370a88e064c516) Original Review URL: https://codereview.chromium.org/1297723002 . R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/09d33bcd82a82cb55039d41651df13e17d6c3e59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -607 lines) Patch
M core/include/fxcrt/fx_basic.h View 1 chunk +0 lines, -69 lines 0 comments Download
M core/include/fxge/fx_font.h View 4 chunks +10 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/font_int.h View 2 chunks +14 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 2 chunks +18 lines, -33 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 2 chunks +8 lines, -13 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/pageint.h View 1 chunk +1 line, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 2 chunks +9 lines, -10 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 3 chunks +7 lines, -4 lines 0 comments Download
M core/src/fxcodec/codec/codec_int.h View 2 chunks +10 lines, -5 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_icc.cpp View 4 chunks +14 lines, -15 lines 0 comments Download
M core/src/fxcrt/fx_basic_maps.cpp View 2 chunks +0 lines, -192 lines 0 comments Download
M core/src/fxge/apple/fx_mac_imp.cpp View 2 chunks +8 lines, -7 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 12 chunks +54 lines, -59 lines 0 comments Download
M core/src/fxge/ge/fx_ge_linux.cpp View 3 chunks +23 lines, -24 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 4 chunks +15 lines, -18 lines 0 comments Download
M fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h View 2 chunks +0 lines, -8 lines 0 comments Download
M fpdfsdk/include/fsdk_annothandler.h View 2 chunks +3 lines, -1 line 0 comments Download
M fpdfsdk/include/javascript/global.h View 2 chunks +3 lines, -1 line 0 comments Download
M fpdfsdk/src/fsdk_annothandler.cpp View 2 chunks +6 lines, -12 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 9 chunks +55 lines, -81 lines 0 comments Download
M xfa/src/fdp/src/css/fde_csscache.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fdp/src/css/fde_csscache.cpp View 3 chunks +31 lines, -44 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
Lei, needs careful review. Thanks.
5 years, 4 months ago (2015-08-18 15:55:05 UTC) #1
Lei Zhang
lgtm I only reviewed the manual edits.
5 years, 4 months ago (2015-08-18 22:38:26 UTC) #2
Tom Sepez
5 years, 4 months ago (2015-08-19 16:49:30 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
09d33bcd82a82cb55039d41651df13e17d6c3e59 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698