Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 130173004: Revert of Revert of Never send a referrer header if the referrer is not a web url (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 11 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Revert of Revert of Never send a referrer header if the referrer is not a web url (https://codereview.chromium.org/133863003/) Reason for revert: Fixed the browser test meanwhile. Original issue's description: > Revert of Never send a referrer header if the referrer is not a web url (https://codereview.chromium.org/136583002/) > > Reason for revert: > This is the probable cause for the failing browser test CorrectReferrer. See: > > http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/1302/steps/browser_tests/logs/CorrectReferrer > > http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/5398/steps/browser_tests/logs/CorrectReferrer > > http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/543/steps/browser_tests/logs/CorrectReferrer > > Original issue's description: > > Never send a referrer header if the referrer is not a web url > > > > BUG=none > > R=abarth@chromium.org > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165085 > > TBR=abarth@chromium.org,jochen@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=none > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165090 TBR=abarth@chromium.org,tdanderson@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/weborigin/SecurityPolicy.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
A Source/platform/weborigin/SecurityPolicyTest.cpp View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Revert of Never send a referrer header if the referrer is not ...
6 years, 11 months ago (2014-01-15 15:32:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/130173004/1
6 years, 11 months ago (2014-01-15 15:43:49 UTC) #2
commit-bot: I haz the power
6 years, 11 months ago (2014-01-15 15:58:12 UTC) #3
Message was sent while issue was closed.
Change committed as 165140

Powered by Google App Engine
This is Rietveld 408576698