Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1301693002: Fix the mechanism by which Blink determines OSX version number. (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
Reviewers:
Nico
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix the mechanism by which Blink determines OSX version number. Previously, Blink was checking NSAppKitVersionNumber against a compile time constant. This mechanism doesn't work (see the bug for more details). This CL converts the logic to use the same mechanism that Chromium uses. BUG=521034 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200708

Patch Set 1 #

Patch Set 2 : Formatting. #

Patch Set 3 : Minor fixes. #

Patch Set 4 : Add a missing return; to a unit test. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -15 lines) Patch
M Source/platform/blink_platform.gypi View 1 2 1 chunk +1 line, -0 lines 2 comments Download
M Source/platform/mac/ThemeMac.mm View 1 2 2 chunks +3 lines, -9 lines 0 comments Download
M Source/platform/mac/VersionUtilMac.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/platform/mac/VersionUtilMac.mm View 1 2 1 chunk +64 lines, -6 lines 0 comments Download
A Source/platform/mac/VersionUtilMacTest.mm View 1 2 3 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
erikchen
thakis: Please review.
5 years, 4 months ago (2015-08-17 22:56:54 UTC) #2
Nico
lgtm :-( Hopefully we can just use the version from base in blink soon. https://codereview.chromium.org/1301693002/diff/60001/Source/platform/blink_platform.gypi ...
5 years, 4 months ago (2015-08-18 00:11:27 UTC) #3
erikchen
https://codereview.chromium.org/1301693002/diff/60001/Source/platform/blink_platform.gypi File Source/platform/blink_platform.gypi (right): https://codereview.chromium.org/1301693002/diff/60001/Source/platform/blink_platform.gypi#newcode984 Source/platform/blink_platform.gypi:984: 'mac/VersionUtilMacTest.mm', On 2015/08/18 00:11:27, Nico wrote: > This file ...
5 years, 4 months ago (2015-08-18 00:14:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301693002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301693002/60001
5 years, 4 months ago (2015-08-18 00:14:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99452)
5 years, 4 months ago (2015-08-18 02:07:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301693002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301693002/60001
5 years, 4 months ago (2015-08-18 05:59:29 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=200708
5 years, 4 months ago (2015-08-18 07:10:22 UTC) #11
tkent
5 years, 4 months ago (2015-08-18 07:39:53 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1286233004/ by tkent@chromium.org.

The reason for reverting is: VersionUtilMac.AppKitVersions fails on OSX 10.6 and
10.7.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...
.

Powered by Google App Engine
This is Rietveld 408576698