Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1301663002: Privatize GrBatch subclass overrides (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@drawsonvb
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -115 lines) Patch
M src/gpu/GrAAConvexPathRenderer.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 3 chunks +23 lines, -22 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 2 chunks +1 line, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 10 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 2 chunks +1 line, -1 line 0 comments Download
M src/gpu/batches/GrAAFillRectBatch.cpp View 2 chunks +26 lines, -27 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrBWFillRectBatch.cpp View 2 chunks +20 lines, -20 lines 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/batches/GrStrokeRectBatch.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 2 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
bsalomon
5 years, 4 months ago (2015-08-17 20:42:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301663002/20001
5 years, 4 months ago (2015-08-17 20:42:43 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-17 20:42:44 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 4 months ago (2015-08-18 02:42:04 UTC) #7
joshualitt
On 2015/08/18 02:42:04, commit-bot: I haz the power wrote: > No LGTM from a valid ...
5 years, 4 months ago (2015-08-18 13:03:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301663002/20001
5 years, 4 months ago (2015-08-18 13:04:39 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 13:05:17 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e46f9feb44780a6269c6dcfe993f4215427fd98e

Powered by Google App Engine
This is Rietveld 408576698