Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: Source/core/editing/Position.h

Issue 1301643003: Move a member function inRenderedText() out from PositionAlgorithm template class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-20T14:30:47 Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/editing/Position.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/Position.h
diff --git a/Source/core/editing/Position.h b/Source/core/editing/Position.h
index d0f15997a9c45d9c9d219690e0b1e3e896f3b871..1c4fabf06168a6e629e49ceef6920dd0f4cdb1fb 100644
--- a/Source/core/editing/Position.h
+++ b/Source/core/editing/Position.h
@@ -190,7 +190,6 @@ public:
PositionAlgorithm<Strategy> downstream(EditingBoundaryCrossingRule = CannotCrossEditingBoundary) const;
bool isCandidate() const;
- bool inRenderedText() const;
InlineBoxPosition computeInlineBoxPosition(TextAffinity) const;
InlineBoxPosition computeInlineBoxPosition(TextAffinity, TextDirection primaryDirection) const;
@@ -448,6 +447,11 @@ inline PositionInComposedTree fromPositionInDOMTree<EditingInComposedTreeStrateg
// to "VisibleUnits.cpp" to reduce |LayoutObject| dependency in "Position.cpp"
bool hasRenderedNonAnonymousDescendantsWithHeight(LayoutObject*);
+// TODO(yosin) We should move |inRenderedText()| to "VisibleUnits.h" for
+// reduce dependency of |LayoutObject| in |Position| class.
+CORE_EXPORT bool inRenderedText(const Position&);
+CORE_EXPORT bool inRenderedText(const PositionInComposedTree&);
+
} // namespace blink
#ifndef NDEBUG
« no previous file with comments | « no previous file | Source/core/editing/Position.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698