Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1301643003: Move a member function inRenderedText() out from PositionAlgorithm template class (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move a member function inRenderedText() out from PositionAlgorithm template class This patch moves |inRenderedText()| out from |PositionAlgorithm| template class as a preparation of moving |inRenderedText()| to "VisibileUnits.cpp" to reduce dependency of |LayoutObject| in "Position.cpp" for improving code health. BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200890

Patch Set 1 : 2015-08-19T16:08:41 #

Patch Set 2 : 2015-08-19T22:54:21　Use computeEditingOffset() to pass VisibileUnitTest.renderedOffset #

Patch Set 3 : 2015-08-20T14:30:47 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M Source/core/editing/Position.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M Source/core/editing/Position.cpp View 1 2 2 chunks +21 lines, -7 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301643003/1
5 years, 4 months ago (2015-08-19 07:11:09 UTC) #2
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-19 07:37:03 UTC) #4
yoichio
Could you move them to VisibleUnit.cpp in this CL?
5 years, 4 months ago (2015-08-19 07:54:56 UTC) #5
yosin_UTC9
On 2015/08/19 07:54:56, yoichio wrote: > Could you move them to VisibleUnit.cpp in this CL? ...
5 years, 4 months ago (2015-08-19 07:59:35 UTC) #6
yosin_UTC9
On 2015/08/19 07:54:56, yoichio wrote: > Could you move them to VisibleUnit.cpp in this CL? ...
5 years, 4 months ago (2015-08-19 08:02:58 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/95165)
5 years, 4 months ago (2015-08-19 08:33:56 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301643003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301643003/20001
5 years, 4 months ago (2015-08-19 13:55:00 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 17:14:57 UTC) #13
yoichio
lgtm
5 years, 4 months ago (2015-08-20 01:59:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301643003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301643003/20001
5 years, 4 months ago (2015-08-20 04:22:19 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/90433)
5 years, 4 months ago (2015-08-20 04:26:53 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301643003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301643003/40001
5 years, 4 months ago (2015-08-20 05:31:26 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/22157)
5 years, 4 months ago (2015-08-20 05:59:17 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301643003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301643003/40001
5 years, 4 months ago (2015-08-20 08:26:53 UTC) #25
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 09:12:31 UTC) #26
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200890

Powered by Google App Engine
This is Rietveld 408576698