Issue 130163004: Optimize chromium.ico and app_list.ico.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130163004: Optimize chromium.ico and app_list.ico. (Closed)

Created:
6 years, 11 months ago by Matt Giuca

Modified:
6 years, 11 months ago

Reviewers:
oshima

CC:
chromium-reviews, oshima+watch_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Optimize chromium.ico and app_list.ico. Done by extracting the PNG data from the ICO files, applying aggressive optimization, and rebuilding the ICO. Reduces the file size by 7443 bytes in total. BUG=332639 R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244089

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
	M	chrome/app/theme/chromium/app_list.ico	View		Binary file		0 comments	Download
	M	chrome/app/theme/chromium/chromium.ico	View		Binary file		0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/130163004/1

6 years, 11 months ago (2014-01-09 23:21:55 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=44212

6 years, 11 months ago (2014-01-10 00:26:11 UTC) #4

Matt Giuca

6 years, 11 months ago (2014-01-10 04:57:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r244089 (presubmit successful).

Expand Messages | Collapse Messages