Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1301613003: Return partial output when shell.run_and_get_output time limit is hit. (Closed)

Created:
5 years, 4 months ago by ppi
Modified:
5 years, 4 months ago
Reviewers:
etiennej
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Return partial output when shell.run_and_get_output time limit is hit. This patch fixes run_and_get_output() of the Linux shell abstraction so that if the process times out and is forcefully terminated, any output produced by it before termination is still returned to the caller, aligning it with the Android shell abstraction. We also grow simple tests for run_and_get_output(), using 'echo' and 'cat' instead of the real shell binary. R=etiennej@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fdfd6dfc9d529b63f46034e3197cd7932b869acf

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Etienne's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -17 lines) Patch
M mojo/devtools/common/devtoolslib/linux_shell.py View 2 chunks +13 lines, -17 lines 0 comments Download
A mojo/devtools/common/devtoolslib/linux_shell_unittest.py View 1 1 chunk +93 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ppi
Hi Etienne, ptal.
5 years, 4 months ago (2015-08-17 16:23:16 UTC) #2
etiennej
https://codereview.chromium.org/1301613003/diff/1/mojo/devtools/common/devtoolslib/shell_unittest.py File mojo/devtools/common/devtoolslib/shell_unittest.py (right): https://codereview.chromium.org/1301613003/diff/1/mojo/devtools/common/devtoolslib/shell_unittest.py#newcode5 mojo/devtools/common/devtoolslib/shell_unittest.py:5: """Tests for the shell abstraction.""" This is actually about ...
5 years, 4 months ago (2015-08-18 09:58:43 UTC) #3
ppi
https://codereview.chromium.org/1301613003/diff/1/mojo/devtools/common/devtoolslib/shell_unittest.py File mojo/devtools/common/devtoolslib/shell_unittest.py (right): https://codereview.chromium.org/1301613003/diff/1/mojo/devtools/common/devtoolslib/shell_unittest.py#newcode5 mojo/devtools/common/devtoolslib/shell_unittest.py:5: """Tests for the shell abstraction.""" On 2015/08/18 09:58:43, etiennej ...
5 years, 4 months ago (2015-08-18 10:11:05 UTC) #4
etiennej
lgtm
5 years, 4 months ago (2015-08-18 10:54:23 UTC) #5
ppi
5 years, 4 months ago (2015-08-18 10:55:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fdfd6dfc9d529b63f46034e3197cd7932b869acf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698