Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1301583006: Add rendertarget flag to prevent a debug assert in SampleApp. (Closed)

Created:
5 years, 4 months ago by Stephen White
Modified:
5 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add rendertarget flag to prevent a debug assert in SampleApp. BUG=skia:4223 Committed: https://skia.googlesource.com/skia/+/4b013296bf67df6c8d119a8f5a2b3dd6530c0b6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Stephen White
Brian: PTAL. Thanks!
5 years, 4 months ago (2015-08-19 15:44:01 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301583006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301583006/1
5 years, 4 months ago (2015-08-19 15:44:39 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 15:51:09 UTC) #6
bsalomon
lgtm
5 years, 4 months ago (2015-08-19 16:07:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301583006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301583006/1
5 years, 4 months ago (2015-08-19 16:10:01 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 16:10:30 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4b013296bf67df6c8d119a8f5a2b3dd6530c0b6f

Powered by Google App Engine
This is Rietveld 408576698