Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1301583005: Rename ParserInfo::function() and CompilationInfo::function() to literal(). (Closed)

Created:
5 years, 4 months ago by titzer
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rename ParserInfo::function() and CompilationInfo::function() to literal(). R=rossberg@chromium.org BUG= Committed: https://crrev.com/ac3e24c96f8a1d8a8afafbd1c23e28593e2885ba Cr-Commit-Position: refs/heads/master@{#30254}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -111 lines) Patch
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.cc View 1 2 5 chunks +9 lines, -10 lines 0 comments Download
M src/compiler.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler.cc View 1 14 chunks +29 lines, -19 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-visualizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/linkage.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug/debug-scopes.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/full-codegen.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/lithium-allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/parser.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/scopes.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/typing.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-loop-assignment-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 6 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
titzer
5 years, 4 months ago (2015-08-19 14:49:57 UTC) #1
rossberg
LGTM (rubberstamp)
5 years, 4 months ago (2015-08-19 15:16:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301583005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301583005/40001
5 years, 4 months ago (2015-08-19 15:38:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5043)
5 years, 4 months ago (2015-08-19 15:41:52 UTC) #7
Michael Starzinger
LGTM on full-codegen.
5 years, 4 months ago (2015-08-19 16:47:21 UTC) #9
Yang
On 2015/08/19 16:47:21, Michael Starzinger wrote: > LGTM on full-codegen. lgtm on debug
5 years, 4 months ago (2015-08-19 16:49:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301583005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301583005/40001
5 years, 4 months ago (2015-08-19 16:50:16 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-19 16:51:43 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 16:52:00 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ac3e24c96f8a1d8a8afafbd1c23e28593e2885ba
Cr-Commit-Position: refs/heads/master@{#30254}

Powered by Google App Engine
This is Rietveld 408576698