Source/core/frame/PlatformEventDispatcher.h - Issue 1301543002: [Oilpan] Remove a raw pointer to PlatformEventController class on Oilpan build

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/frame/PlatformEventDispatcher.h

Issue 1301543002: [Oilpan] Remove a raw pointer to PlatformEventController class on Oilpan build (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef PlatformEventDispatcher_h	5 #ifndef PlatformEventDispatcher_h

6 #define PlatformEventDispatcher_h	6 #define PlatformEventDispatcher_h

7	7

8 #include "core/CoreExport.h"	8 #include "core/CoreExport.h"

9 #include "platform/heap/Handle.h"	9 #include "platform/heap/Handle.h"

10 #include "wtf/Vector.h"	10 #include "wtf/Vector.h"

(...skipping 12 matching lines...) Expand all Loading...
23 PlatformEventDispatcher();	23 PlatformEventDispatcher();

24	24

25 void notifyControllers();	25 void notifyControllers();

26	26

27 virtual void startListening() = 0;	27 virtual void startListening() = 0;

28 virtual void stopListening() = 0;	28 virtual void stopListening() = 0;

29	29

30 private:	30 private:

31 void purgeControllers();	31 void purgeControllers();

32	32

33 #if ENABLE(OILPAN)	33 WillBeHeapHashSet<RawPtrWillBeWeakMember<PlatformEventController>> m_control lers;

34 void clearWeakMembers(Visitor*);

35 #endif

36

37 WillBeHeapVector<PlatformEventController*> m_controllers;

38 bool m_needsPurge;

39 bool m_isDispatching;
haraken 2015/08/19 11:12:51 We cannot simply remove the purge logic. See my co We cannot simply remove the purge logic. See my comment below. peria 2015/08/20 09:35:50 Acknowledged. Show quoted text On 2015/08/19 11:12:51, haraken wrote: > > We cannot simply remove the purge logic. See my comment below. Acknowledged.
40 };	34 };

41	35

42 } // namespace blink	36 } // namespace blink

43	37

44 #endif // PlatformEventDispatcher_h	38 #endif // PlatformEventDispatcher_h

OLD	NEW

« no previous file with comments | « no previous file | Source/core/frame/PlatformEventDispatcher.cpp » ('j') | Source/core/frame/PlatformEventDispatcher.cpp » ('J')