Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1301533002: Add DCHECK that the script context table do not contain native scripts. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add DCHECK that the script context table do not contain native scripts. This is to prevent unnecessary script contexts to be created for native scripts, which could end up with a script context table containing twenty script contexts for a newly created native context. R=jkummerow@chromium.org Committed: https://crrev.com/f0c21aa487cfab274f21a12c5f64af4b690f1b32 Cr-Commit-Position: refs/heads/master@{#30188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/bootstrapper.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 4 months ago (2015-08-17 06:56:30 UTC) #1
Jakob Kummerow
lgtm
5 years, 4 months ago (2015-08-17 09:37:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301533002/1
5 years, 4 months ago (2015-08-17 09:58:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-17 11:00:48 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 11:01:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0c21aa487cfab274f21a12c5f64af4b690f1b32
Cr-Commit-Position: refs/heads/master@{#30188}

Powered by Google App Engine
This is Rietveld 408576698