[telemetry] Implement per-pixel algorithms in Bitmap as a C++ extension.

[telemetry] Implement per-pixel algorithms in Bitmap as a C++ extension.

The extension provides fast bitmap operations with no external
dependencies. However, it is not available on all platforms.

BUG=323813
TEST=telemetry bitmap_unittest
TBR=bulach@chromium.org, tonyg@chromium.org, maruel@chromium.org
NOTRY=true

This is a third attempt. See bug for previous reviews of this CL.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244067

[szym, 2014-01-10 00:39:36]

Since this CL was reviewed three times. I intend to land this TBR and NOTRY.

Changes since revert:
- sorted OS conditions in lexicographic order
- added a minor fix for VS Express 2010 link.exe
- added sys.argv to assert message (for debugging)
- added one space character in '<(output_path) '

[tonyg, 2014-01-10 00:51:17]

Lgtm. Thanks for persisting. Fingers crossed :)
On Jan 9, 2014 6:39 PM, <szym@chromium.org> wrote:

> Reviewers: bulach, tonyg, M-A Ruel,
>
> Message:
> Since this CL was reviewed three times. I intend to land this TBR and
> NOTRY.
>
> Changes since revert:
> - sorted OS conditions in lexicographic order
> - added a minor fix for VS Express 2010 link.exe
> - added sys.argv to assert message (for debugging)
> - added one space character in '<(output_path) '
>
>
>
> Description:
> [telemetry] Implement per-pixel algorithms in Bitmap as a C++ extension.
>
> The extension provides fast bitmap operations with no external
> dependencies. However, it is not available on all platforms.
>
> BUG=323813
> TEST=telemetry bitmap_unittest
> TBR=bulach@chromium.org, tonyg@chromium.org, maruel@chromium.org
> NOTRY=true
>
> This is a third attempt. See bug for previous reviews of this CL.
>
> Please review this at https://codereview.chromium.org/130153003/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+543, -80 lines):
>   M build/all.gyp
>   M chrome/telemetry.isolate
>   A tools/telemetry/telemetry.gyp
>   M tools/telemetry/telemetry/core/bitmap.py
>   M tools/telemetry/telemetry/core/bitmap_unittest.py
>   A tools/telemetry/telemetry/core/bitmaptools/__init__.py
>   A tools/telemetry/telemetry/core/bitmaptools/bitmaptools.cc
>   A tools/telemetry/telemetry/core/build_extension.py
>   M tools/telemetry/telemetry/core/tab.py
>   M tools/telemetry/telemetry/core/util.py
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-10 02:18:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/szym@chromium.org/130153003/210001

[commit-bot: I haz the power, 2014-01-10 03:17:40]

Change committed as 244067

[szym, 2014-01-10 04:34:33]

So I miscounted -- this is actually the 4th attempt, but I guess 4th time's the
charm.

Credit probably goes to scottmg@ who switched the win builder from msbuild to
ninja. Yay!

[bulach, 2014-01-10 13:42:42]

late lgtm, yaay! :)

[jamesr, 2014-01-10 19:25:56]

This appears to be causing lots of build spam for me on an 'All' build:

[2775/10798] ACTION bitmaptools: bitmaptools_e8b3d442cc814aae2cab15a6fcb20ae3
running build_ext
building 'bitmaptools' extension
creating /tmp/tmp_XJNgK/telemetry
creating /tmp/tmp_XJNgK/telemetry/core
creating /tmp/tmp_XJNgK/telemetry/core/bitmaptools
clang -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes
-fPIC -I/usr/include/python2.7 -c telemetry/core/bitmaptools/bitmaptools.cc -o
/tmp/tmp_XJNgK/telemetry/core/bitmaptools/bitmaptools.o
clang++ -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions
-Wl,-Bsymbolic-functions -Wl,-z,relro
/tmp/tmp_XJNgK/telemetry/core/bitmaptools/bitmaptools.o -o
../../out/Debug/bitmaptools.so
running clean
removing '/tmp/tmp_XJNgK' (and everything under it)
'build/lib.linux-x86_64-2.7' does not exist -- can't clean it
'build/bdist.linux-x86_64' does not exist -- can't clean it
'build/scripts-2.7' does not exist -- can't clean it


please fix - a successful build should not spam the console

[szym, 2014-01-11 18:06:58]

I'm on it. The build spam was only necessary for diagnostics.
On Jan 10, 2014 2:25 PM, <jamesr@chromium.org> wrote:

> This appears to be causing lots of build spam for me on an 'All' build:
>
> [2775/10798] ACTION bitmaptools: bitmaptools_
> e8b3d442cc814aae2cab15a6fcb20ae3
> running build_ext
> building 'bitmaptools' extension
> creating /tmp/tmp_XJNgK/telemetry
> creating /tmp/tmp_XJNgK/telemetry/core
> creating /tmp/tmp_XJNgK/telemetry/core/bitmaptools
> clang -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall
> -Wstrict-prototypes
> -fPIC -I/usr/include/python2.7 -c telemetry/core/bitmaptools/bitmaptools.cc
> -o
> /tmp/tmp_XJNgK/telemetry/core/bitmaptools/bitmaptools.o
> clang++ -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions
> -Wl,-Bsymbolic-functions -Wl,-z,relro
> /tmp/tmp_XJNgK/telemetry/core/bitmaptools/bitmaptools.o -o
> ../../out/Debug/bitmaptools.so
> running clean
> removing '/tmp/tmp_XJNgK' (and everything under it)
> 'build/lib.linux-x86_64-2.7' does not exist -- can't clean it
> 'build/bdist.linux-x86_64' does not exist -- can't clean it
> 'build/scripts-2.7' does not exist -- can't clean it
>
>
> please fix - a successful build should not spam the console
>
> https://codereview.chromium.org/130153003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-01-13 18:06:10]

I filed https://code.google.com/p/chromium/issues/detail?id=333932 about the
exact thing that James said (sorry, didn't see the review until I had already
filed the bug).

[scottmg, 2014-01-15 04:42:03]

On 2014/01/13 18:06:10, Nico wrote:
> I filed https://code.google.com/p/chromium/issues/detail?id=333932 about the
> exact thing that James said (sorry, didn't see the review until I had already
> filed the bug).

This does not work with the automated toolchain on Windows.
https://code.google.com/p/chromium/issues/detail?id=334523

Is it possible to use gyp to build this code instead?

[szym, 2014-01-15 06:05:41]

Work in progress https://codereview.chromium.org/136753005/

I'd appreciate some help with understanding GYP. In particular, right now
when I pass an absolute path, e.g. r'd:\python27\include' as 'include_dirs'
seems to end up as treated as relative and with all '\'s gone.


On Tue, Jan 14, 2014 at 11:42 PM, <scottmg@chromium.org> wrote:

> On 2014/01/13 18:06:10, Nico wrote:
>
>> I filed https://code.google.com/p/chromium/issues/detail?id=333932 about
>> the
>> exact thing that James said (sorry, didn't see the review until I had
>> already
>> filed the bug).
>>
>
> This does not work with the automated toolchain on Windows.
> https://code.google.com/p/chromium/issues/detail?id=334523
>
> Is it possible to use gyp to build this code instead?
>
> https://codereview.chromium.org/130153003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.