Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1301503003: Revert of Enable and fix tests after page serializer merge (Closed)

Created:
5 years, 4 months ago by tkent
Modified:
5 years, 4 months ago
CC:
asanka, benjhayden+dwatch_chromium.org, chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable and fix tests after page serializer merge (patchset #1 id:1 of https://codereview.chromium.org/1219923010/ ) Reason for revert: Needs to revert Blink 198503, which this depends on. Original issue's description: > Enable and fix tests after page serializer merge > > Enable and fix two SavePageBrowserTests and two BrowserEncodingTest that > where removed in <https://codereview.chromium.org/1218743006/>; in > preparation of the page serializer merger in > <https://codereview.chromium.org/1177733003/>;. > > Patch from gustav.tiger@sonymobile.com > > R=jochen@chromium.org, rdsmith@chromium.org > BUG=328354 > > Committed: https://chromium.googlesource.com/chromium/src/+/bbf281076da0c593ec9d586eb78b2498581d070e TBR=jochen@chromium.org,rdsmith@chromium.org,gustav.tiger@sonymobile.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=328354, 510422 Committed: https://chromium.googlesource.com/chromium/src/+/1ee1e16e9853ca88730ec2345933a3d07ec20c04

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 11 (5 generated)
tkent
Created Revert of Enable and fix tests after page serializer merge
5 years, 4 months ago (2015-08-17 03:13:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301503003/1
5 years, 4 months ago (2015-08-17 03:13:29 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/browser/browser_encoding_browsertest.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 4 months ago (2015-08-17 03:13:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301503003/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301503003/200001
5 years, 4 months ago (2015-08-17 03:20:38 UTC) #7
commit-bot: I haz the power
Failed to apply patch for chrome/test/data/encoding_tests/auto_detect/expected_results/expected_gb18030_saved_from_no_encoding_specified.html: While running git apply --index -3 -p1; error: patch ...
5 years, 4 months ago (2015-08-17 03:20:49 UTC) #9
tkent
5 years, 4 months ago (2015-08-17 03:29:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:200001) manually as
1ee1e16e9853ca88730ec2345933a3d07ec20c04 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698