Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: src/jsregexp.cc

Issue 13015: * Make compiler happy by adding unreachable variable assignment. (Closed)
Patch Set: Added fallthrough for native on ARM. Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/jsregexp.cc
diff --git a/src/jsregexp.cc b/src/jsregexp.cc
index b4050fabf5a18c1c479f1cd8aeaa058b1d3d0e6f..439a8d1098a5b54b857950b9cbe8ca9cb99a28ac 100644
--- a/src/jsregexp.cc
+++ b/src/jsregexp.cc
@@ -531,6 +531,7 @@ Handle<Object> RegExpImpl::IrregexpExecOnce(Handle<JSRegExp> regexp,
break;
#else
UNIMPLEMENTED();
+ rc = false;
break;
#endif
}
@@ -2725,7 +2726,7 @@ Handle<FixedArray> RegExpEngine::Compile(RegExpParseResult* input,
if (FLAG_irregexp_native) {
#ifdef ARM
- UNIMPLEMENTED();
+ // Unimplemented, fall-through to bytecode implementation.
#else // IA32
RegExpMacroAssemblerIA32 macro_assembler(RegExpMacroAssemblerIA32::UC16,
(input->capture_count + 1) * 2);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698