Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1301473003: Suppress -Wswitch for pdfium's fxge target for now. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Nico
5 years, 4 months ago (2015-08-16 18:42:16 UTC) #2
Lei Zhang
lgtm
5 years, 4 months ago (2015-08-17 03:42:23 UTC) #3
Nico
5 years, 4 months ago (2015-08-17 04:17:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fdc8f439e854a2636e7d22d7104bf08cf5620b0b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698