Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1301403002: Fix extended master secret implementation in tlslite (Closed)

Created:
5 years, 4 months ago by nharper
Modified:
5 years, 4 months ago
Reviewers:
davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix extended master secret implementation in tlslite The previous cl (http://crrev.com/1306553002) didn't properly handle the field in HandshakeSettings, resulting in extended master secret always being enabled, regardless of what was passed in. BUG=467312 Committed: https://crrev.com/b6248b5a92ab416011b4aadcb40adc83cab00c35 Cr-Commit-Position: refs/heads/master@{#344846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M third_party/tlslite/patches/extended_master_secret.patch View 2 chunks +9 lines, -1 line 0 comments Download
M third_party/tlslite/tlslite/handshakesettings.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nharper
5 years, 4 months ago (2015-08-21 20:01:31 UTC) #2
davidben
Bah, I should have noticed that. That's bitten me so many times... lgtm.
5 years, 4 months ago (2015-08-21 20:02:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301403002/1
5 years, 4 months ago (2015-08-21 20:05:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 20:18:48 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 20:19:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6248b5a92ab416011b4aadcb40adc83cab00c35
Cr-Commit-Position: refs/heads/master@{#344846}

Powered by Google App Engine
This is Rietveld 408576698