Issue 13014: Rudimentary assertion expansion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13014: Rudimentary assertion expansion (Closed)

Created:
12 years ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Visibility:
Public.

Description

- Added some expansion of assertions. - Splitting of character classes into word and non-word parts. - A bunch of refactorings. - Made dispatch table construction lazy.

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+614 lines, -133 lines)			Patch
M	src/char-predicates.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/char-predicates-inl.h	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	src/jsregexp.h	View	19 chunks	+167 lines, -21 lines	1 comment	Download
M	src/jsregexp.cc	View	15 chunks	+381 lines, -86 lines	0 comments	Download
M	test/cctest/test-regexp.cc	View	6 chunks	+45 lines, -26 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

12 years ago (2008-12-01 11:55:47 UTC) #2

LGTM.

http://codereview.chromium.org/13014/diff/1/5
File src/jsregexp.h (right):

http://codereview.chromium.org/13014/diff/1/5#newcode447
Line 447: enum TriBool {
Not really a better name. Not that I can think of one that is, but TriBool is
simply wrong (either it's three or it's a bool).

http://codereview.chromium.org/13014/diff/1/6
File test/cctest/test-regexp.cc (right):

http://codereview.chromium.org/13014/diff/1/6#newcode325
Line 325: static bool NotWord(uc16 c) {
Symmetry suggests NotRegExpWord.

http://codereview.chromium.org/13014/diff/1/6#newcode346
Line 346: TestCharacterClassEscapes('.', IsRegExpNewline);
Shouldn't this be IsNOTRegExpNewline?

Expand Messages | Collapse Messages