Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1301393012: [turbofan] Split before loops. (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
jvoung (off chromium), Jim Stichnoth, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Split before loops. If the range doesn't have calls, but still fails to allocate, try and find a split position outside a loop. BUG= Committed: https://crrev.com/f050c53c9a1ba8adfbb1ab0e41f8dda668666bd7 Cr-Commit-Position: refs/heads/master@{#30580}

Patch Set 1 #

Patch Set 2 : Perf #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M src/compiler/greedy-allocator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/greedy-allocator.cc View 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mircea Trofin
5 years, 3 months ago (2015-09-04 07:53:44 UTC) #2
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-04 08:22:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301393012/20002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301393012/20002
5 years, 3 months ago (2015-09-04 08:23:25 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:20002)
5 years, 3 months ago (2015-09-04 08:28:06 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 08:28:19 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f050c53c9a1ba8adfbb1ab0e41f8dda668666bd7
Cr-Commit-Position: refs/heads/master@{#30580}

Powered by Google App Engine
This is Rietveld 408576698