Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Issue 1301393004: Remove Linux ARM Compile from main waterfall. (Closed)

Created:
5 years, 3 months ago by jam
Modified:
5 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Remove Linux ARM Compile from main waterfall. The motivation for this was to ensure ARM compiles don't break and to run some NaCl browser tests on ARM. The former is handled by the chromeos_daisy bot on the CQ and main waterfall, which builds our ARM shipping configuration. For the latter (tests), we don't run tests on the CQ anyways, and those can be run through ChromeoS images instead. This bot remains on chromium.fyi. BUG=384104 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296475

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : no need for linux_arm_compile, just use linux_arm trybot #

Patch Set 4 : fix per phajdan #

Patch Set 5 : merge #

Messages

Total messages: 36 (17 generated)
jam
5 years, 3 months ago (2015-08-24 21:33:17 UTC) #2
Sam Clegg
On 2015/08/24 21:33:17, jam wrote: Do we have a trybot that we can use the ...
5 years, 3 months ago (2015-08-24 22:49:48 UTC) #3
Sam Clegg
On 2015/08/24 22:49:48, Sam Clegg wrote: > On 2015/08/24 21:33:17, jam wrote: > > Do ...
5 years, 3 months ago (2015-08-24 22:58:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301393004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301393004/1
5 years, 3 months ago (2015-08-25 20:33:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit/builds/1301)
5 years, 3 months ago (2015-08-25 20:39:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301393004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301393004/20001
5 years, 3 months ago (2015-08-25 21:00:47 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit/builds/1303)
5 years, 3 months ago (2015-08-25 21:06:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301393004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301393004/40001
5 years, 3 months ago (2015-08-25 21:25:54 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit/builds/1305)
5 years, 3 months ago (2015-08-25 21:32:11 UTC) #18
jam
Pawel, can you review, and also help me figure out why the presubmit is failing? ...
5 years, 3 months ago (2015-08-25 21:37:08 UTC) #20
Paweł Hajdan Jr.
I think you'd also need to remove it from recipe_modules/chromium_tests/chromium_linux.py (remember to regenerate test expectations).
5 years, 3 months ago (2015-08-27 14:58:43 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301393004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301393004/60001
5 years, 3 months ago (2015-08-27 20:09:24 UTC) #23
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 3 months ago (2015-08-27 20:09:27 UTC) #25
jam
On 2015/08/27 14:58:43, Paweł Hajdan Jr. wrote: > I think you'd also need to remove ...
5 years, 3 months ago (2015-08-27 20:13:22 UTC) #26
Paweł Hajdan Jr.
LGTM The errors seem unrelated. Consider reporting them on c-i-t.
5 years, 3 months ago (2015-08-28 11:47:10 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301393004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301393004/60001
5 years, 3 months ago (2015-08-28 17:34:50 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit/builds/1372)
5 years, 3 months ago (2015-08-28 17:36:27 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301393004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301393004/80001
5 years, 3 months ago (2015-08-28 17:57:20 UTC) #35
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 18:00:48 UTC) #36
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296475

Powered by Google App Engine
This is Rietveld 408576698