Expose durable storage to workers.

Expose durable storage method to workers.

And add a layout test.

BUG=520717
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201015

[dgrogan, 2015-08-20 23:02:02]

dgrogan@chromium.org changed reviewers:
+ jsbell@chromium.org

[dgrogan, 2015-08-20 23:15:11]

Josh, can you see what I'm doing wrong in StorageManager.idl? If not I'll
escalate to the bindings team.

I'm getting a compile error in the second to last substantive line in the paste
below, which is from gen/blink/bindings/modules/v8/V8StorageManager.cpp. The
error is that there's nothing to the left of the "->".

void V8StorageManager::preparePrototypeObject(v8::Isolate* isolate,
v8::Local<v8::Object> prototypeObject, v8::Local<v8::FunctionTemplate>
interfaceTemplate)
{
    v8::Local<v8::Signature> defaultSignature = v8::Signature::New(isolate,
domTemplate(isolate));
    ExecutionContext* context =
toExecutionContext(prototypeObject->CreationContext());
    ASSERT(context);
    if (context && (context->isDocument())) {
        v8::Local<v8::FunctionTemplate> functionTemplate =
v8::FunctionTemplate::New(isolate,
StorageManagerV8Internal::requestPersistentMethodCallback, v8Undefined(),
defaultSignature, 0);
        v8::Local<v8::Function> function =
->GetFunction(isolate->GetCurrentContext())).ToLocalChecked();
        v8CallOrCrash(prototypeObject->Set(isolate->GetCurrentContext(),
v8AtomicString(isolate, "requestPersistent"), function));
    }
}

https://codereview.chromium.org/1301393002/diff/1/Source/modules/quota/Storag...
File Source/modules/quota/StorageManager.idl (right):

https://codereview.chromium.org/1301393002/diff/1/Source/modules/quota/Storag...
Source/modules/quota/StorageManager.idl:15: [Exposed=Window,
CallWith=ScriptState] Promise<boolean> requestPersistent();
Here.

[jsbell, 2015-08-20 23:34:34]

On 2015/08/20 23:15:11, dgrogan wrote:
> Josh, can you see what I'm doing wrong in StorageManager.idl? If not I'll
> escalate to the bindings team.

IDL looks fine to me, it's almost certainly a bug in the code generator, so I'd
escalate to yukishiino and haraken.

[dgrogan, 2015-08-20 23:42:28]

dgrogan@chromium.org changed reviewers:
+ yukishiino@chromium.org

[dgrogan, 2015-08-20 23:42:28]

Yuki, could you look to see if what I'm trying to do in StorageManager.idl is
supported by the code generator? I pasted the generated code in this crrev and
there's an obvious omission... Let me know how I should proceed.

[Yuki, 2015-08-21 06:55:11]

On 2015/08/20 23:42:28, dgrogan wrote:
> Yuki, could you look to see if what I'm trying to do in StorageManager.idl is
> supported by the code generator? I pasted the generated code in this crrev and
> there's an obvious omission... Let me know how I should proceed.

Oops, sorry for the build breakage.
I'm now sending a fix for review.  Should be committed soon.
https://codereview.chromium.org/1309653002/

[dgrogan, 2015-08-21 18:29:38]

Yuki, thanks for the fix.

Josh, could you review this?

[jsbell, 2015-08-21 19:05:29]

lgtm

I think
LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
will need updating too - can you check?

https://codereview.chromium.org/1301393002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/storage/resources/durability-worker.js (right):

https://codereview.chromium.org/1301393002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/storage/resources/durability-worker.js:6: test(function()
{ assert_false("requestPersistent" in navigator.storage); },
On the TODO list (but low priority): we should add idlharness tests

[dgrogan, 2015-08-21 19:08:21]

On 2015/08/21 19:05:29, jsbell wrote:
> lgtm
> 
> I think
>
LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
> will need updating too - can you check?

I think that's the first file listed - did you mean something different?

[jsbell, 2015-08-21 19:11:39]

On 2015/08/21 19:08:21, dgrogan wrote:
> On 2015/08/21 19:05:29, jsbell wrote:
> > lgtm
> > 
> > I think
> >
>
LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
> > will need updating too - can you check?
> 
> I think that's the first file listed - did you mean something different?

Whoops. Need more coffee. :P

lgtm ++!

[dgrogan, 2015-08-21 19:13:08]

The CQ bit was checked by dgrogan@chromium.org

[commit-bot: I haz the power, 2015-08-21 19:13:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1301393002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1301393002/40001

[commit-bot: I haz the power, 2015-08-21 21:23:12]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201015