Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 1301333005: Convert denormalised-voiced-japanese-chars.html to a reference test. (Closed)

Created:
5 years, 3 months ago by tkent
Modified:
5 years, 3 months ago
Reviewers:
kojii
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Convert denormalised-voiced-japanese-chars.html to a reference test. Also, remove an obsoleted comment in TestExpectations. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201361

Patch Set 1 #

Patch Set 2 : Swap the test and the reference. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -101 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/encoding/denormalised-voiced-japanese-chars.html View 1 1 chunk +2 lines, -6 lines 0 comments Download
A + LayoutTests/fast/encoding/denormalised-voiced-japanese-chars-expected.html View 1 1 chunk +2 lines, -6 lines 0 comments Download
D LayoutTests/platform/linux/fast/encoding/denormalised-voiced-japanese-chars-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/encoding/denormalised-voiced-japanese-chars-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/encoding/denormalised-voiced-japanese-chars-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/encoding/denormalised-voiced-japanese-chars-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/platform/win/fast/encoding/denormalised-voiced-japanese-chars-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/encoding/denormalised-voiced-japanese-chars-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tkent
kojii@, would you review this please? My main purpose was to remove the comment, and ...
5 years, 3 months ago (2015-08-28 01:03:44 UTC) #2
kojii
LGTM, I wonder why I didn't do that at the first place, thank you so ...
5 years, 3 months ago (2015-08-28 01:20:21 UTC) #3
tkent
On 2015/08/28 01:20:21, kojii wrote: > nit: I'd swap test and -expected, so that the ...
5 years, 3 months ago (2015-08-28 03:06:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301333005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301333005/20001
5 years, 3 months ago (2015-08-28 03:06:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201361
5 years, 3 months ago (2015-08-28 03:11:03 UTC) #8
kojii
5 years, 3 months ago (2015-08-28 03:38:00 UTC) #9
Message was sent while issue was closed.
Thank you!

Powered by Google App Engine
This is Rietveld 408576698