make ProxyService::CreateSystemProxyConfigService return scoped_ptrs NOT FOR REVIEW

net/url_request/url_request_context_builder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_context_builder.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
@@ skipping 263 matching lines @@
 
   if (!host_resolver_) {
     host_resolver_ = HostResolver::CreateDefaultResolver(context->net_log());
   }
   storage->set_host_resolver(host_resolver_.Pass());
 
   if (!proxy_service_) {
     // TODO(willchan): Switch to using this code when
     // ProxyService::CreateSystemProxyConfigService()'s signature doesn't suck.
   #if defined(OS_LINUX) || defined(OS_ANDROID)
-    ProxyConfigService* proxy_config_service = proxy_config_service_.release();
+    scoped_ptr<ProxyConfigService> proxy_config_service(
+        proxy_config_service_.release());

[Randy Smith (Not in Mondays), 2015/08/24 21:58:19]

I think that .Pass() would be more idiomatic here than .release().

   #else
-    ProxyConfigService* proxy_config_service = NULL;
+    scoped_ptr<ProxyConfigService> proxy_config_service;
     if (proxy_config_service_) {
-      proxy_config_service = proxy_config_service_.release();
+      proxy_config_service.reset(proxy_config_service_.release());

[Randy Smith (Not in Mondays), 2015/08/24 21:58:19]

Why not "proxy_config_service = proxy_config_service_.Pass();"?

     } else {
       proxy_config_service = ProxyService::CreateSystemProxyConfigService(
           base::ThreadTaskRunnerHandle::Get().get(),
           context->GetFileTaskRunner());
     }
   #endif  // defined(OS_LINUX) || defined(OS_ANDROID)
-    proxy_service_.reset(
-        ProxyService::CreateUsingSystemProxyResolver(
-            proxy_config_service,
-            0,  // This results in using the default value.
-            context->net_log()));
+    proxy_service_.reset(ProxyService::CreateUsingSystemProxyResolver(
+        proxy_config_service.Pass(),
+        0,  // This results in using the default value.
+        context->net_log()));
   }
   storage->set_proxy_service(proxy_service_.release());
 
   storage->set_ssl_config_service(new SSLConfigServiceDefaults);
   HttpAuthHandlerRegistryFactory* http_auth_handler_registry_factory =
       HttpAuthHandlerRegistryFactory::CreateDefault(context->host_resolver());
   for (size_t i = 0; i < extra_http_auth_handlers_.size(); ++i) {
     http_auth_handler_registry_factory->RegisterSchemeFactory(
         extra_http_auth_handlers_[i].scheme,
         extra_http_auth_handlers_[i].factory);
@@ skipping 131 matching lines @@
     }
     url_request_interceptors_.weak_clear();
   }
   storage->set_job_factory(top_job_factory.release());
   // TODO(willchan): Support sdch.
 
   return context;
 }
 
 }  // namespace net