Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: net/proxy/proxy_service_v8.h

Issue 1301333002: make ProxyService::CreateSystemProxyConfigService return scoped_ptrs NOT FOR REVIEW (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: try merging again... Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/proxy/proxy_service_unittest.cc ('k') | net/proxy/proxy_service_v8.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_PROXY_PROXY_SERVICE_V8_H_ 5 #ifndef NET_PROXY_PROXY_SERVICE_V8_H_
6 #define NET_PROXY_PROXY_SERVICE_V8_H_ 6 #define NET_PROXY_PROXY_SERVICE_V8_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "net/base/net_export.h" 10 #include "net/base/net_export.h"
(...skipping 21 matching lines...) Expand all
32 // |host_resolver| points to the host resolving dependency the PAC script 32 // |host_resolver| points to the host resolving dependency the PAC script
33 // should use for any DNS queries. It must remain valid throughout the 33 // should use for any DNS queries. It must remain valid throughout the
34 // lifetime of the ProxyService. 34 // lifetime of the ProxyService.
35 // 35 //
36 // ########################################################################## 36 // ##########################################################################
37 // # See the warnings in net/proxy/proxy_resolver_v8.h describing the 37 // # See the warnings in net/proxy/proxy_resolver_v8.h describing the
38 // # multi-threading model. In order for this to be safe to use, *ALL* the 38 // # multi-threading model. In order for this to be safe to use, *ALL* the
39 // # other V8's running in the process must use v8::Locker. 39 // # other V8's running in the process must use v8::Locker.
40 // ########################################################################## 40 // ##########################################################################
41 NET_EXPORT scoped_ptr<ProxyService> CreateProxyServiceUsingV8ProxyResolver( 41 NET_EXPORT scoped_ptr<ProxyService> CreateProxyServiceUsingV8ProxyResolver(
42 ProxyConfigService* proxy_config_service, 42 scoped_ptr<ProxyConfigService> proxy_config_service,
43 ProxyScriptFetcher* proxy_script_fetcher, 43 ProxyScriptFetcher* proxy_script_fetcher,
44 DhcpProxyScriptFetcher* dhcp_proxy_script_fetcher, 44 DhcpProxyScriptFetcher* dhcp_proxy_script_fetcher,
45 HostResolver* host_resolver, 45 HostResolver* host_resolver,
46 NetLog* net_log, 46 NetLog* net_log,
47 NetworkDelegate* network_delegate); 47 NetworkDelegate* network_delegate);
48 48
49 } // namespace net 49 } // namespace net
50 50
51 #endif // NET_PROXY_PROXY_SERVICE_V8_H_ 51 #endif // NET_PROXY_PROXY_SERVICE_V8_H_
OLDNEW
« no previous file with comments | « net/proxy/proxy_service_unittest.cc ('k') | net/proxy/proxy_service_v8.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698