Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1301323006: SkOncePtr (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkOncePtr New abstraction to replace all of: SkOnce, SkLazyPtr, SkLazyFnPtr. BUG=skia: Committed: https://skia.googlesource.com/skia/+/714a710c428c3166b729b7756199927ab85eb69e

Patch Set 1 #

Patch Set 2 : no inheritance #

Patch Set 3 : typo #

Patch Set 4 : Non-copyable #

Patch Set 5 : drop destructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -0 lines) Patch
A include/private/SkOncePtr.h View 1 2 3 4 1 chunk +102 lines, -0 lines 0 comments Download
A tests/OncePtrTest.cpp View 1 2 3 4 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
mtklein_C
5 years, 3 months ago (2015-09-03 19:17:02 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301323006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301323006/1
5 years, 3 months ago (2015-09-03 19:17:18 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-03 19:21:57 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301323006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301323006/20001
5 years, 3 months ago (2015-09-03 19:53:18 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3000)
5 years, 3 months ago (2015-09-03 19:54:00 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301323006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301323006/40001
5 years, 3 months ago (2015-09-03 19:55:29 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301323006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301323006/60001
5 years, 3 months ago (2015-09-03 19:56:32 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-03 20:01:45 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301323006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301323006/80001
5 years, 3 months ago (2015-09-03 20:04:13 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-03 20:09:46 UTC) #20
herb_g
lgtm
5 years, 3 months ago (2015-09-04 17:24:21 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301323006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301323006/80001
5 years, 3 months ago (2015-09-04 17:25:49 UTC) #23
mtklein
Working on the big follow up now.
5 years, 3 months ago (2015-09-04 17:25:56 UTC) #24
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 17:26:30 UTC) #25
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/714a710c428c3166b729b7756199927ab85eb69e

Powered by Google App Engine
This is Rietveld 408576698