Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 13011: Use char instead of wchar_t for counter names.... (Closed)

Created:
12 years ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Use char instead of wchar_t for counter names. Counters should be ASCII anyway, and wchar_t is four bytes per character on non-Windows platforms.

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -22 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/counters.h View 3 chunks +3 lines, -5 lines 0 comments Download
M src/d8.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/d8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mksnapshot.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/v8-counters.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Martin
Though the v8 contributor wiki says to send a patch to the mailing list, running ...
12 years ago (2008-12-01 01:10:13 UTC) #1
Dean McNamee
LGTM On 2008/12/01 01:10:13, Evan Martin wrote: > Though the v8 contributor wiki says to ...
12 years ago (2008-12-01 02:42:47 UTC) #2
Christian Plesner Hansen
Thanks for changing this. I've always been uneasy about us using wchar_t for this (for ...
12 years ago (2008-12-01 07:24:33 UTC) #3
Mads Ager (chromium)
12 years ago (2008-12-01 07:41:53 UTC) #4
I have committed this in v8 bleeding_edge revision 871.

Powered by Google App Engine
This is Rietveld 408576698