Plumb CompositedDisplayList to WebViewImpl

Source/web/WebViewImpl.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 253 matching lines @@
     void hidePopups() override;
     void setPageOverlayColor(WebColor) override;
     void transferActiveWheelFlingAnimation(const WebActiveWheelFlingParameters&) override;
     bool endActiveFlingAnimation() override;
     void setShowPaintRects(bool) override;
     void setShowDebugBorders(bool);
     void setShowFPSCounter(bool) override;
     void setShowScrollBottleneckRects(bool) override;
     void acceptLanguagesChanged() override;
 
+    void setCompositedDisplayList(WebCompositedDisplayList*) override;
+    WebCompositedDisplayList* compositedDisplayList() override;
+
     // WebViewImpl
     void enableViewport();
     void disableViewport();
 
     float defaultMinimumPageScaleFactor() const;
     float defaultMaximumPageScaleFactor() const;
     float minimumPageScaleFactor() const;
     float maximumPageScaleFactor() const;
     float clampPageScaleFactorToLimits(float) const;
     void resetScrollAndScaleStateImmediately();
@@ skipping 449 matching lines @@
     WebLayerTreeView* m_layerTreeView;
     WebLayer* m_rootLayer;
     GraphicsLayer* m_rootGraphicsLayer;
     GraphicsLayer* m_rootTransformLayer;
     OwnPtr<GraphicsLayerFactory> m_graphicsLayerFactory;
     bool m_matchesHeuristicsForGpuRasterization;
     // If true, the graphics context is being restored.
     bool m_recreatingGraphicsContext;
     static const WebInputEvent* m_currentInputEvent;
 
+    OwnPtr<WebCompositedDisplayList> m_compositedDisplayList;

[jbroman, 2015/08/19 18:33:50]

Nit: we could consider making WebCompositedDisplayList a member of WebViewImpl,
since it is itself already basically an OwnPtr<CompositedDisplayList>
internally. Then you'd forward the PassOwnPtr<CompositedDisplayList> all the way
into WebViewImpl, where you would do
m_compositedDisplayList.assign(passCompositedDisplayList) or similar.

i.e. here:
    WebCompositedDisplayList m_compositedDisplayList;
in the impl:
    void WebViewImpl::setCompositedDisplayList(PassOwnPtr<CompositedDisplayList>
compositedDisplayList)
    {
        m_compositedDisplayList.assign(compositedDisplayList);
    }
    WebCompositedDisplayList* WebViewImpl::compositedDisplayList() { return
&m_compositedDisplayList; }

I don't feel very strongly about this instance, though.

[pdr., 2015/08/20 04:01:55]

This worked out nicely since it moves the WebCDL <-> CDL logic up a bit and out
of Page.

+
     MediaKeysClientImpl m_mediaKeysClientImpl;
     OwnPtr<WebActiveGestureAnimation> m_gestureAnimation;
     WebPoint m_positionOnFlingStart;
     WebPoint m_globalPositionOnFlingStart;
     int m_flingModifier;
     bool m_flingSourceDevice;
     Vector<OwnPtr<LinkHighlightImpl>> m_linkHighlights;
     OwnPtr<WebCompositorAnimationTimeline> m_linkHighlightsTimeline;
     OwnPtrWillBePersistent<FullscreenController> m_fullscreenController;
 
@@ skipping 13 matching lines @@
 };
 
 DEFINE_TYPE_CASTS(WebViewImpl, WebWidget, widget, widget->isWebView(), widget.isWebView());
 // We have no ways to check if the specified WebView is an instance of
 // WebViewImpl because WebViewImpl is the only implementation of WebView.
 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
 
 } // namespace blink
 
 #endif