Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: Source/core/editing/Position.cpp

Issue 1301023003: Move static member functions next{Previous,Next}Offset() and uncheckedPreviousOffsetForBackwardDelet (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-20T14:28:12 Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/Position.h ('k') | Source/core/editing/PositionIterator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/Position.cpp
diff --git a/Source/core/editing/Position.cpp b/Source/core/editing/Position.cpp
index 6716f960a70ab8033c29ccc9d94401ea67a8e9c0..01e2887ea8eb4665b2ac5925421331a8c5109125 100644
--- a/Source/core/editing/Position.cpp
+++ b/Source/core/editing/Position.cpp
@@ -314,6 +314,10 @@ int PositionAlgorithm<Strategy>::compareTo(const PositionAlgorithm<Strategy>& ot
return comparePositions(*this, other);
}
+// TODO(yosin) To avoid forward declaration, we should move implementation of
+// |uncheckedPreviousOffsetForBackwardDeletion()| here.
+static int uncheckedPreviousOffsetForBackwardDeletion(const Node*, int current);
+
template <typename Strategy>
PositionAlgorithm<Strategy> PositionAlgorithm<Strategy>::previous(PositionMoveType moveType) const
{
@@ -384,20 +388,17 @@ PositionAlgorithm<Strategy> PositionAlgorithm<Strategy>::next(PositionMoveType m
return PositionAlgorithm<Strategy>(*this);
}
-template <typename Strategy>
-int PositionAlgorithm<Strategy>::uncheckedPreviousOffset(const Node* n, int current)
+int uncheckedPreviousOffset(const Node* n, int current)
{
return n->layoutObject() ? n->layoutObject()->previousOffset(current) : current - 1;
}
-template <typename Strategy>
-int PositionAlgorithm<Strategy>::uncheckedPreviousOffsetForBackwardDeletion(const Node* n, int current)
+static int uncheckedPreviousOffsetForBackwardDeletion(const Node* n, int current)
{
return n->layoutObject() ? n->layoutObject()->previousOffsetForBackwardDeletion(current) : current - 1;
}
-template <typename Strategy>
-int PositionAlgorithm<Strategy>::uncheckedNextOffset(const Node* n, int current)
+int uncheckedNextOffset(const Node* n, int current)
{
return n->layoutObject() ? n->layoutObject()->nextOffset(current) : current + 1;
}
« no previous file with comments | « Source/core/editing/Position.h ('k') | Source/core/editing/PositionIterator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698