Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1301023003: Move static member functions next{Previous,Next}Offset() and uncheckedPreviousOffsetForBackwardDelet (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move static member functions next{Previous,Next}Offset() and uncheckedPreviousOffsetForBackwardDeletion() out from PositionAlgorithm<Strategy> template class This patch moves a member function |next{Previous,Next}Offset()| and |uncheckedPreviousOffsetForBackwardDeletion()| out from |PositionAlgorithm<Strategy>| template class as non-member functions since they are independent from |Strategy| template parameter to simplify class declaration for improving code halth. BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200892

Patch Set 1 : 2015-08-19T14:25:29 #

Patch Set 2 : 2015-08-20T14:28:12 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M Source/core/editing/Position.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/Position.cpp View 1 2 chunks +7 lines, -6 lines 0 comments Download
M Source/core/editing/PositionIterator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-19 05:59:11 UTC) #2
yoichio
How about moving to PositionIterator.cpp as static function because only it uses them?
5 years, 4 months ago (2015-08-19 06:07:15 UTC) #3
yosin_UTC9
On 2015/08/19 06:07:15, yoichio wrote: > How about moving to PositionIterator.cpp as static function because ...
5 years, 4 months ago (2015-08-19 06:27:40 UTC) #4
yoichio
lgtm
5 years, 4 months ago (2015-08-20 04:25:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301023003/1
5 years, 4 months ago (2015-08-20 04:41:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/87221) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-20 04:42:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301023003/20001
5 years, 4 months ago (2015-08-20 05:29:13 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/110830)
5 years, 4 months ago (2015-08-20 05:59:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301023003/20001
5 years, 4 months ago (2015-08-20 08:26:35 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 09:27:04 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200892

Powered by Google App Engine
This is Rietveld 408576698