Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: src/IceGlobalContext.h

Issue 1300993002: Use separate random number generator for each randomization pass (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceGlobalContext.h
diff --git a/src/IceGlobalContext.h b/src/IceGlobalContext.h
index 7f27024490974a743f01a0096884d347468d882e..e07e577e98616ccc8b462c5e11b3dda8b3bb281d 100644
--- a/src/IceGlobalContext.h
+++ b/src/IceGlobalContext.h
@@ -243,10 +243,6 @@ public:
const Intrinsics &getIntrinsicsInfo() const { return IntrinsicsInfo; }
- // TODO(wala,stichnot): Make the RNG play nicely with multithreaded
- // translation.
- RandomNumberGenerator &getRNG() { return RNG; }
-
ELFObjectWriter *getObjectWriter() const { return ObjectWriter.get(); }
/// Reset stats at the beginning of a function.
@@ -440,10 +436,6 @@ public:
return Match.empty() || Match == SymbolName;
}
- /// Return the randomization cookie for diversification.
- /// Initialize the cookie if necessary
- uint32_t getRandomizationCookie() const { return RandomizationCookie; }
-
private:
// Try to ensure mutexes are allocated on separate cache lines.
@@ -496,7 +488,6 @@ private:
Intrinsics IntrinsicsInfo;
const ClFlags &Flags;
- RandomNumberGenerator RNG; // TODO(stichnot): Move into Cfg.
// TODO(jpp): move to EmitterContext.
std::unique_ptr<ELFObjectWriter> ObjectWriter;
BoundedProducerConsumerQueue<Cfg> OptQ;
@@ -557,11 +548,6 @@ private:
typedef llvm::SmallVector<char, 32> ManglerVector;
void incrementSubstitutions(ManglerVector &OldName) const;
- // Randomization Cookie
- // Managed by getRandomizationCookie()
- GlobalLockType RandomizationCookieLock;
- uint32_t RandomizationCookie = 0;
-
public:
static void TlsInit() { ICE_TLS_INIT_FIELD(TLS); }
};
« no previous file with comments | « src/IceELFObjectWriter.cpp ('k') | src/IceGlobalContext.cpp » ('j') | src/IceRegAlloc.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698