media/base/mock_media_log.h - Issue 1300943002: MSE: Verify MediaLog events created by existing WebM unit tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/mock_media_log.h

Issue 1300943002: MSE: Verify MediaLog events created by existing WebM unit tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/mock_media_log.h

diff --git a/media/base/mock_media_log.h b/media/base/mock_media_log.h

index 04c011633c400895680301e79746c920f0cbae65..05088ccda90f77b467a698bb22f8dcde86621bc3 100644

--- a/media/base/mock_media_log.h

+++ b/media/base/mock_media_log.h

@@ -8,6 +8,12 @@

#include "media/base/media_log.h"

#include "testing/gmock/include/gmock/gmock.h"

+// Helper macro to reduce boilerplate when verifying media log entries.

+// "media_log_" is expected to be a scoped_refptr<MockMediaLog>, optionally a

+// StrictMock, in scope of the usage of this macro.

+#define EXPECT_MEDIA_LOG_STRING(x) \

wolenetz 2015/08/18 21:13:48 I lifted this helper macro out of SourceBufferStre

+ EXPECT_CALL(*media_log_, DoAddEventLogString((x)))

namespace media {

class MockMediaLog : public MediaLog {

« no previous file with comments | « no previous file | media/filters/source_buffer_stream_unittest.cc » ('j') | media/formats/webm/webm_cluster_parser_unittest.cc » ('J')