Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 130093003: Accessibility: chrome://history keyboarding issues. (Closed)

Created:
6 years, 11 months ago by hshi1
Modified:
6 years, 11 months ago
Reviewers:
Patrick Dubroy, xiyuan
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Accessibility: chrome://history keyboarding issues. Apply aria-haspopup attribute to actions buttons. BUG=320753 TEST=ctrl+alt+z, tab to actions button and hear "action pop-up button". R=xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243929

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/history/history.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hshi1
+Patrick (OWNERS of chrome/browser/resources/history) PTAL The "aria-haspopup" attribute ensures that spoken feedback for the action ...
6 years, 11 months ago (2014-01-09 00:54:32 UTC) #1
hshi1
+xiyuan for review (Patrick seems to be offline). Thanks!
6 years, 11 months ago (2014-01-09 17:39:14 UTC) #2
xiyuan
lgtm
6 years, 11 months ago (2014-01-09 17:57:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hshi@chromium.org/130093003/1
6 years, 11 months ago (2014-01-09 17:59:39 UTC) #4
hshi1
6 years, 11 months ago (2014-01-09 18:19:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r243929 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698