Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3121)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_result_view.cc

Issue 1300843003: Change width of rows in material design omnibox dropdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change left/right to start/end Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_result_view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/omnibox/omnibox_result_view.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
index 238b048e2d5a4016911f3aa51801dbda1413296f..dfbbda5d0ad64d164ba8534490eb833a04becd99 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
@@ -624,26 +624,25 @@ void OmniboxResultView::Layout() {
const int trailing_padding = theme_provider->GetDisplayProperty(
ThemeProperties::PROPERTY_ICON_LABEL_VIEW_TRAILING_PADDING);
+ const int start_x = StartMargin() + horizontal_padding;
+ const int end_x = width() - EndMargin() - horizontal_padding;
+
icon_bounds_.SetRect(
- horizontal_padding +
- ((icon.width() == default_icon_size_) ? 0 : trailing_padding),
- (GetContentLineHeight() - icon.height()) / 2, icon.width(),
- icon.height());
+ start_x + ((icon.width() == default_icon_size_) ? 0 : trailing_padding),
+ (GetContentLineHeight() - icon.height()) / 2,
+ icon.width(), icon.height());
- int text_x = (2 * horizontal_padding) + default_icon_size_;
- int text_width = width() - text_x - horizontal_padding;
+ const int text_x = start_x + default_icon_size_ + horizontal_padding;
+ int text_width = end_x - text_x;
if (match_.associated_keyword.get()) {
- const int kw_collapsed_size = keyword_icon_->width() + horizontal_padding;
- const int max_kw_x = width() - kw_collapsed_size;
- const int kw_x =
- animation_->CurrentValueBetween(max_kw_x, horizontal_padding);
+ const int max_kw_x = end_x - keyword_icon_->width();
+ const int kw_x = animation_->CurrentValueBetween(max_kw_x, start_x);
const int kw_text_x = kw_x + keyword_icon_->width() + horizontal_padding;
text_width = kw_x - text_x - horizontal_padding;
keyword_text_bounds_.SetRect(
- kw_text_x, 0, std::max(width() - kw_text_x - horizontal_padding, 0),
- height());
+ kw_text_x, 0, std::max(end_x - kw_text_x, 0), height());
keyword_icon_->SetPosition(
gfx::Point(kw_x, (height() - keyword_icon_->height()) / 2));
}
@@ -652,7 +651,7 @@ void OmniboxResultView::Layout() {
}
void OmniboxResultView::OnBoundsChanged(const gfx::Rect& previous_bounds) {
- animation_->SetSlideDuration(width() / 4);
+ animation_->SetSlideDuration((width() - StartMargin() - EndMargin()) / 4);
}
void OmniboxResultView::OnPaint(gfx::Canvas* canvas) {
@@ -799,3 +798,13 @@ void OmniboxResultView::AppendAnswerTextHelper(gfx::RenderText* destination,
GetNativeTheme()->GetSystemColor(text_style.colors[GetState()]), range);
destination->ApplyBaselineStyle(text_style.baseline, range);
}
+
+int OmniboxResultView::StartMargin() const {
+ return ui::MaterialDesignController::IsModeMaterial() ?
+ model_->start_margin() : 0;
+}
+
+int OmniboxResultView::EndMargin() const {
+ return ui::MaterialDesignController::IsModeMaterial() ?
+ model_->end_margin() : 0;
+}
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_result_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698