Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1300833002: Enable MediaDevices.enumerateDevices and let promises-based getUserMedia behind a flag. (Closed)

Created:
5 years, 4 months ago by Guido Urdaneta
Modified:
5 years, 3 months ago
CC:
blink-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use separate flags for MediaDevices and promises-based getUserMedia. getUserMedia is not yet fully spec compliant and should remain behind a flag, but MediaDevices.enumerateDevices does not have this problem. BUG=504280 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201398

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Update global stable interface listing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M Source/modules/mediastream/MediaDevices.idl View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/NavigatorUserMedia.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 3 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 29 (16 generated)
Guido Urdaneta
Hi, PTAL. Security review: crbug.com/268977 Intent to ship: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/MediaDevices/blink-dev/rB8fgNxpQCA
5 years, 4 months ago (2015-08-18 08:51:34 UTC) #2
tommi (sloooow) - chröme
rubberstamp lgtm.
5 years, 4 months ago (2015-08-18 12:47:31 UTC) #3
Guido Urdaneta
esprehn@chromium.org: Please review changes in
5 years, 4 months ago (2015-08-21 08:14:30 UTC) #6
Guido Urdaneta
senorblanco@chromium.org: Please review changes in /Source/platform
5 years, 4 months ago (2015-08-25 08:30:18 UTC) #10
Guido Urdaneta
tkent@chromium.org: PTAL
5 years, 3 months ago (2015-08-27 16:35:40 UTC) #14
tkent
lgtm. I confirmed intent-to-ship of Promise-based getUserMedia had 3 LGTMs.
5 years, 3 months ago (2015-08-27 23:17:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300833002/1
5 years, 3 months ago (2015-08-28 08:29:36 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/62657) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-08-28 08:30:50 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300833002/20001
5 years, 3 months ago (2015-08-28 09:44:04 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/105910)
5 years, 3 months ago (2015-08-28 11:11:01 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300833002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300833002/40001
5 years, 3 months ago (2015-08-28 11:25:22 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201398
5 years, 3 months ago (2015-08-28 12:50:16 UTC) #28
agrieve
5 years, 3 months ago (2015-08-28 16:34:43 UTC) #29
Message was sent while issue was closed.
On 2015/08/28 12:50:16, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:40001) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=201398

Looks like this is calling a buildbot failure:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20We...

Powered by Google App Engine
This is Rietveld 408576698