Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1300813007: wire up reduced atlas and zero textblob cache to test (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

wire up reduced atlas and zero textblob cache to test BUG=skia: Committed: https://skia.googlesource.com/skia/+/7f9c9eb91e65f2d83474f2b34f9ed0d9525245ae

Patch Set 1 #

Total comments: 2

Patch Set 2 : added comments #

Patch Set 3 : feedback inc #

Patch Set 4 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -9 lines) Patch
M src/gpu/GrTest.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 2 2 chunks +26 lines, -0 lines 0 comments Download
M src/gpu/GrTextBlobCache.h View 1 chunk +1 line, -2 lines 0 comments Download
M tests/TextBlobCacheTest.cpp View 1 2 3 4 chunks +21 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
joshualitt
ptal, a small change, but take a peek at the GrTextBlobCache.h change
5 years, 4 months ago (2015-08-19 17:17:53 UTC) #2
joshualitt
adding Robert
5 years, 4 months ago (2015-08-19 17:18:34 UTC) #4
bsalomon
https://codereview.chromium.org/1300813007/diff/1/src/gpu/GrTest.cpp File src/gpu/GrTest.cpp (right): https://codereview.chromium.org/1300813007/diff/1/src/gpu/GrTest.cpp#newcode23 src/gpu/GrTest.cpp:23: configs[kA8_GrMaskFormat].fWidth = 256; comments about why these numbers? https://codereview.chromium.org/1300813007/diff/1/src/gpu/GrTest.h ...
5 years, 4 months ago (2015-08-19 19:54:17 UTC) #5
joshualitt
feedback inc
5 years, 4 months ago (2015-08-19 20:02:52 UTC) #6
joshualitt
On 2015/08/19 20:02:52, joshualitt wrote: > feedback inc ping
5 years, 4 months ago (2015-08-21 17:05:29 UTC) #7
bsalomon
lgtm
5 years, 4 months ago (2015-08-21 17:49:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300813007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300813007/40001
5 years, 4 months ago (2015-08-21 17:50:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/2777)
5 years, 4 months ago (2015-08-21 17:53:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300813007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300813007/60001
5 years, 4 months ago (2015-08-21 18:01:41 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 18:08:03 UTC) #16
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/7f9c9eb91e65f2d83474f2b34f9ed0d9525245ae

Powered by Google App Engine
This is Rietveld 408576698