Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Unified Diff: chrome/browser/chromeos/preferences.cc

Issue 13008005: Short-term fix for CapsLock remapping on chromebooks with external keyboard (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Keep existing pref name Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/ash/event_rewriter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/preferences.cc
diff --git a/chrome/browser/chromeos/preferences.cc b/chrome/browser/chromeos/preferences.cc
index a2e940edc6d95f30e645cfb473febe6eff171af3..be518a9d7f1c65ee3b381ec7b5578eb64eba5b73 100644
--- a/chrome/browser/chromeos/preferences.cc
+++ b/chrome/browser/chromeos/preferences.cc
@@ -259,10 +259,13 @@ void Preferences::RegisterUserPrefs(
prefs::kLanguageRemapAltKeyTo,
input_method::kAltKey,
user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
+ // We don't sync the CapsLock remapping pref, since the UI hides this pref
+ // on certain devices, so syncing a non-default value to a device that
+ // doesn't allow changing the pref would be odd. http://crbug.com/167237
registry->RegisterIntegerPref(
prefs::kLanguageRemapCapsLockKeyTo,
input_method::kCapsLockKey,
- user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
+ user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
registry->RegisterIntegerPref(
prefs::kLanguageRemapDiamondKeyTo,
input_method::kControlKey,
« no previous file with comments | « no previous file | chrome/browser/ui/ash/event_rewriter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698