Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1300783005: Scale x/y coordinate of svg path separately for hit-test (Closed)

Created:
5 years, 4 months ago by Yufeng Shen (Slow to review)
Modified:
5 years, 3 months ago
Reviewers:
pdr., f(malita), fs
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, Rick Byers, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Scale x/y coordinate of svg path separately for hit-test We currently scale x/y coordinate of svg path using the same scale factor for hit-test. It has the problem that when x/y values have different magnitudes, e.g. when x has huge value and y has small value, scaling down x and y using the same scale factor will clamp the y values and make it lose the resolution for hit-test. Scaling x/y separately can fix the problem. BUG=379320 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201192

Patch Set 1 #

Total comments: 7

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -7 lines) Patch
A LayoutTests/svg/hittest/svg-small-big-path.html View 1 1 chunk +49 lines, -0 lines 0 comments Download
A LayoutTests/svg/hittest/svg-small-big-path-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/platform/graphics/skia/SkiaUtils.cpp View 1 2 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
Yufeng Shen (Slow to review)
5 years, 4 months ago (2015-08-19 23:16:47 UTC) #2
pdr.
The path scaling workaround was added a looong time ago (https://bugs.webkit.org/show_bug.cgi?id=84117). Do we still need ...
5 years, 4 months ago (2015-08-19 23:26:15 UTC) #4
fs
On 2015/08/19 23:26:15, pdr wrote: > The path scaling workaround was added a looong time ...
5 years, 4 months ago (2015-08-20 07:47:35 UTC) #5
f(malita)
> Coincidently, by chance I was staring at this code just prior to my vacation ...
5 years, 4 months ago (2015-08-20 09:29:06 UTC) #6
pdr.
I'm okay with this patch as well, but I filed crbug.com/523102 in case anyone wants ...
5 years, 4 months ago (2015-08-20 21:25:13 UTC) #7
jbroman
https://codereview.chromium.org/1300783005/diff/1/LayoutTests/svg/hittest/svg-small-big-path.html File LayoutTests/svg/hittest/svg-small-big-path.html (right): https://codereview.chromium.org/1300783005/diff/1/LayoutTests/svg/hittest/svg-small-big-path.html#newcode1 LayoutTests/svg/hittest/svg-small-big-path.html:1: <style> On 2015/08/20 at 21:25:13, pdr wrote: > <DOCTYPE ...
5 years, 4 months ago (2015-08-20 21:28:20 UTC) #8
Yufeng Shen (Slow to review)
https://codereview.chromium.org/1300783005/diff/1/LayoutTests/svg/hittest/svg-small-big-path.html File LayoutTests/svg/hittest/svg-small-big-path.html (right): https://codereview.chromium.org/1300783005/diff/1/LayoutTests/svg/hittest/svg-small-big-path.html#newcode1 LayoutTests/svg/hittest/svg-small-big-path.html:1: <style> On 2015/08/20 21:28:20, jbroman wrote: > On 2015/08/20 ...
5 years, 4 months ago (2015-08-24 20:13:07 UTC) #9
Yufeng Shen (Slow to review)
OWNERS, mind taking another look ?
5 years, 3 months ago (2015-08-26 00:43:56 UTC) #10
pdr.
lgtm
5 years, 3 months ago (2015-08-26 02:18:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300783005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300783005/20001
5 years, 3 months ago (2015-08-26 02:18:10 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 03:19:04 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201192

Powered by Google App Engine
This is Rietveld 408576698