chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 1300763002: Add a flag to enable open in window for hosted apps on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 1300763002: Add a flag to enable open in window for hosted apps on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@disable-new-bookmark-apps

Patch Set: Addressing reviewer feedback Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_context_menu.cc ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index 00357d6175ce39282020a2bca4d0a262938cc25e..19992b6b5ccddb9dd7e90b476f4c319f7f226e92 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -15,6 +15,7 @@

#include "chrome/app/chrome_command_ids.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/download/download_shelf.h"

+#include "chrome/browser/extensions/extension_util.h"

#include "chrome/browser/extensions/tab_helper.h"

#include "chrome/browser/fullscreen.h"

#include "chrome/browser/profiles/profile.h"

@@ -582,7 +583,11 @@ void BrowserWindowCocoa::ShowBookmarkAppBubble(

base::scoped_nsobject<NSView> view([[NSView alloc]

initWithFrame:NSMakeRect(0, 0, kBookmarkAppBubbleViewWidth,

kBookmarkAppBubbleViewHeight)]);

- [view addSubview:open_as_window_checkbox];

+ // When CanHostedAppsOpenInWindows is disabled, do not show the open as window

tapted 2015/08/20 00:44:02 nit: -> `CanHostedAppsOpenInWindows()` since it's

+ // checkbox to avoid confusing users.

+ if (extensions::util::CanHostedAppsOpenInWindows())

+ [view addSubview:open_as_window_checkbox];

[view addSubview:app_title];

[alert setAccessoryView:view];