chrome/browser/ui/app_list/app_context_menu.cc - Issue 1300763002: Add a flag to enable open in window for hosted apps on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_context_menu.cc

Issue 1300763002: Add a flag to enable open in window for hosted apps on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@disable-new-bookmark-apps

Patch Set: Clarifying logic for open in window Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/launch_util.cc ('K') | « chrome/browser/extensions/launch_util.cc ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/app_context_menu.cc

diff --git a/chrome/browser/ui/app_list/app_context_menu.cc b/chrome/browser/ui/app_list/app_context_menu.cc

index bb955c1f3bfe9aaa14c710a28ff9f1094febd3ea..a364c2a487dd502b728cb8fa94fd5864fc9f2caf 100644

--- a/chrome/browser/ui/app_list/app_context_menu.cc

+++ b/chrome/browser/ui/app_list/app_context_menu.cc

@@ -118,8 +118,10 @@ ui::MenuModel* AppContextMenu::GetMenuModel() {

// When bookmark apps are enabled, hosted apps can only toggle between

// USE_LAUNCH_TYPE_WINDOW and USE_LAUNCH_TYPE_REGULAR.

if (extensions::util::IsNewBookmarkAppsEnabled()) {

benwells 2015/08/19 02:39:21 Ditto

dominickn 2015/08/19 05:21:58 Done.

- menu_model_->AddCheckItemWithStringId(USE_LAUNCH_TYPE_WINDOW,

- IDS_APP_CONTEXT_MENU_OPEN_WINDOW);

+ if (extensions::util::CanHostedAppsOpenInWindows()) {

+ menu_model_->AddCheckItemWithStringId(

+ USE_LAUNCH_TYPE_WINDOW, IDS_APP_CONTEXT_MENU_OPEN_WINDOW);

+ }

} else {

menu_model_->AddCheckItemWithStringId(

USE_LAUNCH_TYPE_REGULAR,