DevTools: render DOM markers with their colors

DevTools: render DOM markers with their colors

BUG=521200
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200757

[pfeldman, 2015-08-18 00:30:17]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2015-08-18 18:35:21]

lgtm with comments

https://codereview.chromium.org/1300743002/diff/1/Source/devtools/front_end/e...
File Source/devtools/front_end/elements/ElementsTreeElement.js (right):

https://codereview.chromium.org/1300743002/diff/1/Source/devtools/front_end/e...
Source/devtools/front_end/elements/ElementsTreeElement.js:1134: if
(!decorations.length && !descendantDecorations.length)
nit: can move this above colors and titles.

https://codereview.chromium.org/1300743002/diff/1/Source/devtools/front_end/e...
Source/devtools/front_end/elements/ElementsTreeElement.js:1166: for (var color
of colors) {
Should we limit the number of colors rendered to prevent overflow?

https://codereview.chromium.org/1300743002/diff/1/Source/devtools/front_end/e...
Source/devtools/front_end/elements/ElementsTreeElement.js:1171:
child.style.marginLeft = offset + "px";
Why not put them into a container which handles offset automatically?

https://codereview.chromium.org/1300743002/diff/1/Source/devtools/front_end/m...
File Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/1300743002/diff/1/Source/devtools/front_end/m...
Source/devtools/front_end/main/Main.js:173: "tooltips",
Please revert, there is a separate patch.

[pfeldman, 2015-08-18 18:40:05]

https://codereview.chromium.org/1300743002/diff/1/Source/devtools/front_end/e...
File Source/devtools/front_end/elements/ElementsTreeElement.js (right):

https://codereview.chromium.org/1300743002/diff/1/Source/devtools/front_end/e...
Source/devtools/front_end/elements/ElementsTreeElement.js:1134: if
(!decorations.length && !descendantDecorations.length)
On 2015/08/18 18:35:20, dgozman wrote:
> nit: can move this above colors and titles.

Done.

https://codereview.chromium.org/1300743002/diff/1/Source/devtools/front_end/e...
Source/devtools/front_end/elements/ElementsTreeElement.js:1166: for (var color
of colors) {
On 2015/08/18 18:35:20, dgozman wrote:
> Should we limit the number of colors rendered to prevent overflow?

it is 3 currently :) lets see when it overflows?

https://codereview.chromium.org/1300743002/diff/1/Source/devtools/front_end/e...
Source/devtools/front_end/elements/ElementsTreeElement.js:1171:
child.style.marginLeft = offset + "px";
On 2015/08/18 18:35:20, dgozman wrote:
> Why not put them into a container which handles offset automatically?

It is extensible, so I don't really know how many containers I would need.

https://codereview.chromium.org/1300743002/diff/1/Source/devtools/front_end/m...
File Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/1300743002/diff/1/Source/devtools/front_end/m...
Source/devtools/front_end/main/Main.js:173: "tooltips",
On 2015/08/18 18:35:21, dgozman wrote:
> Please revert, there is a separate patch.

Done. It was an accident.

[pfeldman, 2015-08-18 18:42:04]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-08-18 18:42:04]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1300743002/#ps20001
(title: "for landing")

[commit-bot: I haz the power, 2015-08-18 18:42:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300743002/20001

[commit-bot: I haz the power, 2015-08-18 19:44:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 19:44:19]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2015-08-18 20:05:59]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2015-08-18 20:06:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300743002/20001

[commit-bot: I haz the power, 2015-08-18 22:07:52]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200757