Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Unified Diff: Source/devtools/front_end/emulation/OverridesUI.js

Issue 1300703004: DevTools: only set title w/ shortcut via Tooltip manager API. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/emulation/OverridesUI.js
diff --git a/Source/devtools/front_end/emulation/OverridesUI.js b/Source/devtools/front_end/emulation/OverridesUI.js
index 185f40cd3dcbeceff7006439ab743bb411d74bb5..f25a3ea627ead651c137448bb2fdccaac4915cba 100644
--- a/Source/devtools/front_end/emulation/OverridesUI.js
+++ b/Source/devtools/front_end/emulation/OverridesUI.js
@@ -21,14 +21,14 @@ WebInspector.DeviceSelect = function(rotateButton, callback)
var container = this.element.createChild("div", "mode-container");
container.appendChild(this._rotateButton);
this._rotateButton.addEventListener("click", this._rotateButtonClicked.bind(this), false);
- WebInspector.Tooltip.install(this._rotateButton, WebInspector.UIString("Change orientation"));
+ this._rotateButton.title = WebInspector.UIString("Change orientation");
var modeSelectContainer = container.createChild("span", "mode-select");
this._modeSelectElement = modeSelectContainer.createChild("select");
this._modeSelectElement.addEventListener("change", this._modeSelected.bind(this), false);
this._modeLabelElement = modeSelectContainer.createChild("label");
this._modeLabelElement.addEventListener("click", this._rotateButtonClicked.bind(this), false);
- WebInspector.Tooltip.install(this._modeLabelElement, WebInspector.UIString("Change orientation"));
+ this._modeLabelElement.title = WebInspector.UIString("Change orientation");
this._emulatedSettingChangedMuted = false;
this._lastOrientation = null;
« no previous file with comments | « Source/devtools/front_end/emulation/DevicesSettingsTab.js ('k') | Source/devtools/front_end/emulation/OverridesView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698