Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: Source/devtools/front_end/ui/treeoutline.js

Issue 1300703004: DevTools: only set title w/ shortcut via Tooltip manager API. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/ui/Tooltip.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 580 matching lines...) Expand 10 before | Expand all | Expand 10 after
591 this._listItemNode.appendChild(this._title); 591 this._listItemNode.appendChild(this._title);
592 this._ensureSelection(); 592 this._ensureSelection();
593 } 593 }
594 }, 594 },
595 595
596 /** 596 /**
597 * @param {string} x 597 * @param {string} x
598 */ 598 */
599 set tooltip(x) 599 set tooltip(x)
600 { 600 {
601 WebInspector.Tooltip.install(this._listItemNode, x); 601 this._listItemNode.title = x;
602 }, 602 },
603 603
604 /** 604 /**
605 * @return {boolean} 605 * @return {boolean}
606 */ 606 */
607 isExpandable: function() 607 isExpandable: function()
608 { 608 {
609 return this._expandable; 609 return this._expandable;
610 }, 610 },
611 611
(...skipping 456 matching lines...) Expand 10 before | Expand all | Expand 10 after
1068 isEventWithinDisclosureTriangle: function(event) 1068 isEventWithinDisclosureTriangle: function(event)
1069 { 1069 {
1070 // FIXME: We should not use getComputedStyle(). For that we need to get rid of using ::before for disclosure triangle. (http://webk.it/74446) 1070 // FIXME: We should not use getComputedStyle(). For that we need to get rid of using ::before for disclosure triangle. (http://webk.it/74446)
1071 var paddingLeftValue = window.getComputedStyle(this._listItemNode).paddi ngLeft; 1071 var paddingLeftValue = window.getComputedStyle(this._listItemNode).paddi ngLeft;
1072 console.assert(paddingLeftValue.endsWith("px")); 1072 console.assert(paddingLeftValue.endsWith("px"));
1073 var computedLeftPadding = parseFloat(paddingLeftValue); 1073 var computedLeftPadding = parseFloat(paddingLeftValue);
1074 var left = this._listItemNode.totalOffsetLeft() + computedLeftPadding; 1074 var left = this._listItemNode.totalOffsetLeft() + computedLeftPadding;
1075 return event.pageX >= left && event.pageX <= left + TreeElement._ArrowTo ggleWidth && this._expandable; 1075 return event.pageX >= left && event.pageX <= left + TreeElement._ArrowTo ggleWidth && this._expandable;
1076 } 1076 }
1077 } 1077 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/ui/Tooltip.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698